Saurabh Singh <singhsrb@fb.com> [Tue, 03 Oct 2017 13:05:58 -0700] rev 34451
test-merge-subrepos: make test compatible with chg
The test checks the output of '.hg/blackbox.log' which will contain
logs corresponding to chg in case chg is running. Therefore, this commit
modifies the test to take chg into consideration while checking the
blackbox.log contents.
Test Plan:
Ran the test 'test-merge-subrepos.t' with and without the '--chg'
option.
Differential Revision: https://phab.mercurial-scm.org/D925
Saurabh Singh <singhsrb@fb.com> [Tue, 03 Oct 2017 12:49:28 -0700] rev 34450
test-convert-cvs: make test compatible with chg
The test uses the 'print' method instead of writing to stdout using
'ui.write' which leads to incompatibility with chg. This commit modifies the
test to use the 'ui' object instead which fixes the problem.
Test Plan:
Ran the test 'test-convert-cvs.t' with and without '--chg' option.
Differential Revision: https://phab.mercurial-scm.org/D923
Saurabh Singh <singhsrb@fb.com> [Tue, 03 Oct 2017 12:09:23 -0700] rev 34449
test-basic: make test compatible with chg
The error codes returned when writing to /dev/full are different after
the first failure with and without '--chg' option. Therefore, this commit
conditionally handles the error codes as appropriate.
Test Plan:
Ran the test 'test-basic.t' with and without '--chg' option.
Differential Revision: https://phab.mercurial-scm.org/D922
Jun Wu <quark@fb.com> [Mon, 02 Oct 2017 20:23:25 -0700] rev 34448
zeroconf: do not crash if socket being read is closed by another thread
In zeroconf/__init__.py, there is:
server = Zeroconf.Zeroconf(ip)
l = listener()
Zeroconf.ServiceBrowser(server, "_hg._tcp.local.", l)
time.sleep(1)
server.close()
`server.close()` closes the underlying socket while the `ServiceBrowser` may
still have a background thread reading the socket. There could be a race
condition where the reading thread reads the closed socket, resulting in
EBADF crash. This patch catches the exception.
This makes test-paths.t pass with chg.
Differential Revision: https://phab.mercurial-scm.org/D919
Jun Wu <quark@fb.com> [Mon, 02 Oct 2017 19:31:33 -0700] rev 34447
test-revlog-mmapindex: make it compatible with chg
The test misses an explicit flush().
Differential Revision: https://phab.mercurial-scm.org/D918
Jun Wu <quark@fb.com> [Mon, 02 Oct 2017 19:10:32 -0700] rev 34446
test-profile: gate chg-incompatible part with '#if chg'
chg has a different extension loading logic, which affects the profiler
extension test case. Gate the block with '#if chg' so the test passes with
chg.
Differential Revision: https://phab.mercurial-scm.org/D916
Jun Wu <quark@fb.com> [Mon, 02 Oct 2017 18:22:43 -0700] rev 34445
test-logtoprocess: make it compatible with chg
chg runs more commands and outputs more lines. This patch matches them.
Differential Revision: https://phab.mercurial-scm.org/D914
Saurabh Singh <singhsrb@fb.com> [Tue, 03 Oct 2017 11:10:03 -0700] rev 34444
test-globalopts: make the test compatible with chg
The test fails when run with the '--chg' option. Therefore, this
commit modifies the test to make it compatible with chg.
Test Plan:
Ran 'test-globalopts.t' with and without the '--chg' option.
Differential Revision: https://phab.mercurial-scm.org/D913
Jun Wu <quark@fb.com> [Mon, 02 Oct 2017 16:11:57 -0700] rev 34443
test-pager: make it compatible with chg
chg's runpager implementation is different. It behaves differently for the
"shell=False, command not found" case.
Differential Revision: https://phab.mercurial-scm.org/D911
Gregory Szorc <gregory.szorc@gmail.com> [Mon, 02 Oct 2017 11:03:53 +0100] rev 34442
changelog: use a Factory for default value for files
The default value is compiled into the generated type. This means
that default values are shared between instances. For immutable types
like bool, str, int, and tuple, this is fine. But for mutable types
like list and dict, we need to use attr.Factory() to instantiate a
new instance of the default for each object.
Differential Revision: https://phab.mercurial-scm.org/D901