Mon, 18 May 2015 16:56:04 -0500 MBTextWrapper: drop dedicated __init__ method
Pierre-Yves David <pierre-yves.david@fb.com> [Mon, 18 May 2015 16:56:04 -0500] rev 25210
MBTextWrapper: drop dedicated __init__ method It was only there as a compatibility layer with a version of Python which we do support anymore.
Mon, 18 May 2015 16:54:21 -0500 util: drop the compatibility with Python 2.4 unpacker
Pierre-Yves David <pierre-yves.david@fb.com> [Mon, 18 May 2015 16:54:21 -0500] rev 25209
util: drop the compatibility with Python 2.4 unpacker Python 2.4 compatibility have packed and sailed.
Mon, 18 May 2015 16:52:28 -0500 tests: just use 'response.reason'
Pierre-Yves David <pierre-yves.david@fb.com> [Mon, 18 May 2015 16:52:28 -0500] rev 25208
tests: just use 'response.reason' There is no reason to not have simple code now that Python 2.4 is dead.
Mon, 18 May 2015 16:51:02 -0500 url: drop awful hack around bug in Python 2.4
Pierre-Yves David <pierre-yves.david@fb.com> [Mon, 18 May 2015 16:51:02 -0500] rev 25207
url: drop awful hack around bug in Python 2.4 It's all just a memory now.
Mon, 18 May 2015 16:47:26 -0500 httpconnection: drop Python 2.4 specify hack
Pierre-Yves David <pierre-yves.david@fb.com> [Mon, 18 May 2015 16:47:26 -0500] rev 25206
httpconnection: drop Python 2.4 specify hack Python 2.4.1 doesn't provide the full URI, good for it.
Mon, 18 May 2015 16:46:32 -0500 mail: drop explicit mail import required by Python 2.4
Pierre-Yves David <pierre-yves.david@fb.com> [Mon, 18 May 2015 16:46:32 -0500] rev 25205
mail: drop explicit mail import required by Python 2.4 He's dead, Jim.
Mon, 18 May 2015 16:33:57 -0500 windows: drop Python2.4 specific hack for directory not found handling
Pierre-Yves David <pierre-yves.david@fb.com> [Mon, 18 May 2015 16:33:57 -0500] rev 25204
windows: drop Python2.4 specific hack for directory not found handling A good Python 2.4 hack is a removed Python 2.4 hack.
Mon, 18 May 2015 16:24:16 -0500 notify: drop import required by Python 2.4
Pierre-Yves David <pierre-yves.david@fb.com> [Mon, 18 May 2015 16:24:16 -0500] rev 25203
notify: drop import required by Python 2.4 Toto, I've a feeling we're not in anno 2004 anymore.
Mon, 18 May 2015 16:22:15 -0500 patchbomb: stop explicit import required by Python 2.4
Pierre-Yves David <pierre-yves.david@fb.com> [Mon, 18 May 2015 16:22:15 -0500] rev 25202
patchbomb: stop explicit import required by Python 2.4 Ding Dong, the witch is dead!
Mon, 18 May 2015 16:20:12 -0500 pager: drop python 2.4 hack around subprocess
Pierre-Yves David <pierre-yves.david@fb.com> [Mon, 18 May 2015 16:20:12 -0500] rev 25201
pager: drop python 2.4 hack around subprocess Farewell, we do not need you anymore.
Mon, 18 May 2015 16:18:18 -0500 check-code: drop ban of 'val if cond else otherval' construct
Pierre-Yves David <pierre-yves.david@fb.com> [Mon, 18 May 2015 16:18:18 -0500] rev 25200
check-code: drop ban of 'val if cond else otherval' construct We now have access to this horrible but less bad than 'cond and val or otherval' syntax.
Mon, 18 May 2015 16:30:24 -0500 check-code: entirely drop the 'non-py24.py' file from the test
Pierre-Yves David <pierre-yves.david@fb.com> [Mon, 18 May 2015 16:30:24 -0500] rev 25199
check-code: entirely drop the 'non-py24.py' file from the test There are no Python 2.4 related errors remaining.
Mon, 18 May 2015 16:11:44 -0500 check-code: drop the 'format' built-in
Pierre-Yves David <pierre-yves.david@fb.com> [Mon, 18 May 2015 16:11:44 -0500] rev 25198
check-code: drop the 'format' built-in I'm not clear what it is doing, but one who knows what it is about can now make use of it.
Mon, 18 May 2015 16:09:05 -0500 check-code: drop ban of str.format
Pierre-Yves David <pierre-yves.david@fb.com> [Mon, 18 May 2015 16:09:05 -0500] rev 25197
check-code: drop ban of str.format After discussion with Augie and Matt, we are fine with it being introduced in the code base.
Mon, 18 May 2015 22:40:16 -0400 statichttprepo: remove wrong getattr ladder
Augie Fackler <raf@durin42.com> [Mon, 18 May 2015 22:40:16 -0400] rev 25196
statichttprepo: remove wrong getattr ladder At least as far back as Python 2.6 the .code attribute is always defined, and to the best of my detective skills a .getcode() method has never been a thing.
(0) -10000 -3000 -1000 -300 -100 -15 +15 +100 +300 +1000 +3000 +10000 tip