Gregory Szorc <gregory.szorc@gmail.com> [Wed, 31 Jan 2018 11:24:44 -0800] rev 35910
wireprotoserver: make some instance attributes private
sshserver attempts to conform to a well-defined interface. The instance
attributes changed as part of this commit don't appear to be part of
that interface. So prefix them with _ to mark them as private.
Differential Revision: https://phab.mercurial-scm.org/D1988
Gregory Szorc <gregory.szorc@gmail.com> [Wed, 31 Jan 2018 11:19:47 -0800] rev 35909
wireprotoserver: remove sshserver.getarg()
AFAICT the last consumer of this helper method was removed by
d054cc5c7737 in 2010.
Differential Revision: https://phab.mercurial-scm.org/D1987
Gregory Szorc <gregory.szorc@gmail.com> [Wed, 31 Jan 2018 11:19:05 -0800] rev 35908
wireprotoserver: remove lock references
AFAICT sshserver.lock is unused. The last caller of it disappeared
in 9f6e0e7ef828 ~18 months ago as part of removing code to support
ancient wire protocol commands. Let's remove some dead code.
Differential Revision: https://phab.mercurial-scm.org/D1986
Gregory Szorc <gregory.szorc@gmail.com> [Wed, 31 Jan 2018 11:17:41 -0800] rev 35907
wireprotoserver: remove support for do_<command> handlers (API)
Old versions of wire protocol handlers relied on methods
named do_<command> to handle wire protocol commands. The last
definition of these methods on sshserver was removed by
9f6e0e7ef828 ~2 years ago. I think it's time to not support this
mechanism for defining command handlers.
.. api::
sshserver no longers looks for wire protocol command handlers
in methods named do_<command>. Use @wireproto.wireprotocommand
to declare wire protocol command handler functions.
Differential Revision: https://phab.mercurial-scm.org/D1985
Gregory Szorc <gregory.szorc@gmail.com> [Wed, 31 Jan 2018 10:19:08 -0800] rev 35906
wireprotoserver: make attributes private
These aren't part of the protocol interface. So they should be
_ prefixed.
Differential Revision: https://phab.mercurial-scm.org/D1984
Gregory Szorc <gregory.szorc@gmail.com> [Wed, 31 Jan 2018 10:17:11 -0800] rev 35905
wireprotoserver: remove unused response attribute
I think the last use of this attribute was removed by 2f8adc60e013
in 2010.
Differential Revision: https://phab.mercurial-scm.org/D1983
Gregory Szorc <gregory.szorc@gmail.com> [Wed, 31 Jan 2018 10:09:41 -0800] rev 35904
wireprotoserver: rename p to proto
To aid readability. And to make it easier to search the code base
for protocol instances.
Differential Revision: https://phab.mercurial-scm.org/D1982
Gregory Szorc <gregory.szorc@gmail.com> [Tue, 30 Jan 2018 17:51:57 -0800] rev 35903
wireprotoserver: add some blank lines between methods
Let's make this file slightly easier to read.
Differential Revision: https://phab.mercurial-scm.org/D1981