diff -r bf877ebed866 -r f48b075ff088 contrib/check-code.py --- a/contrib/check-code.py Mon Apr 23 01:39:26 2012 +0200 +++ b/contrib/check-code.py Mon Apr 23 01:39:26 2012 +0200 @@ -73,6 +73,7 @@ (r'^stop\(\)', "don't use 'stop' as a shell function name"), (r'(\[|\btest\b).*-e ', "don't use 'test -e', use 'test -f'"), (r'^alias\b.*=', "don't use alias, use a function"), + (r'if\s*!', "don't use '!' to negate exit status"), ], # warnings []