# HG changeset patch # User Kevin Bullock # Date 1385335750 21600 # Node ID 1648e44edd8dd5376cbe545b29db77839f4ef8db # Parent 6ed9141151bfd462b1737dacdcdd5b8cf93fbd88 mq: prefer a loop to a double-for list comprehension The [x for y in l for x in y] syntax is nigh-incomprehensible, and this is a particularly easy case to expand into a loop since there's no 'if' condition in the list comprehension. diff -r 6ed9141151bf -r 1648e44edd8d hgext/mq.py --- a/hgext/mq.py Sat Nov 23 18:34:32 2013 +0100 +++ b/hgext/mq.py Sun Nov 24 17:29:10 2013 -0600 @@ -1204,7 +1204,9 @@ diffopts = self.diffopts() wlock = repo.wlock() try: - heads = [h for hs in repo.branchmap().itervalues() for h in hs] + heads = [] + for hs in repo.branchmap().itervalues(): + heads.extend(hs) if not heads: heads = [nullid] if repo.dirstate.p1() not in heads and not exact: