# HG changeset patch
# User Gregory Szorc <gregory.szorc@gmail.com>
# Date 1517595222 28800
# Node ID 24a07347aa60df3b59d86ccc1b20b8818f9bffed
# Parent  e5d535621ee15cd695ac0b5fc8236fc87c72713c
check-commit: allow foo_bar naming in functions

nameswithallthewordssmashedtogetherarehardtoread.
especiallyifenglishisnotyourprimarylanguage.

Let's align with the rest of the programming universe and
allow_the_use_of_underscores_in_names.

We took a hand poll at the 5.2 sprint regarding this change and
all but 1 person supported it. The person who didn't expressed
concerns around excessive API breakage if we mass renamed things.
But we're not planning to mass rename things for the sake of
renaming, so all should be well.

Differential Revision: https://phab.mercurial-scm.org/D2010

diff -r e5d535621ee1 -r 24a07347aa60 contrib/check-code.py
--- a/contrib/check-code.py	Tue Oct 08 13:38:02 2019 -0400
+++ b/contrib/check-code.py	Fri Feb 02 10:13:42 2018 -0800
@@ -340,8 +340,6 @@
         ),
         (r'[^\n]\Z', "no trailing newline"),
         (r'(\S[ \t]+|^[ \t]+)\n', "trailing whitespace"),
-        #    (r'^\s+[^_ \n][^_. \n]+_[^_\n]+\s*=',
-        #     "don't use underbars in identifiers"),
         (
             r'^\s+(self\.)?[A-Za-z][a-z0-9]+[A-Z]\w* = ',
             "don't use camelcase in identifiers",
diff -r e5d535621ee1 -r 24a07347aa60 contrib/check-commit
--- a/contrib/check-commit	Tue Oct 08 13:38:02 2019 -0400
+++ b/contrib/check-commit	Fri Feb 02 10:13:42 2018 -0800
@@ -39,12 +39,6 @@
      "summary keyword should be most user-relevant one-word command or topic"),
     (afterheader + r".*\.\s*\n", "don't add trailing period on summary line"),
     (afterheader + r".{79,}", "summary line too long (limit is 78)"),
-    # Forbid "_" in function name.
-    #
-    # We skip the check for cffi related functions. They use names mapping the
-    # name of the C function. C function names may contain "_".
-    (r"\n\+[ \t]+def (?!cffi)[a-z]+_[a-z]",
-     "adds a function with foo_bar naming"),
 ]
 
 word = re.compile(r'\S')
diff -r e5d535621ee1 -r 24a07347aa60 tests/test-contrib-check-commit.t
--- a/tests/test-contrib-check-commit.t	Tue Oct 08 13:38:02 2019 -0400
+++ b/tests/test-contrib-check-commit.t	Fri Feb 02 10:13:42 2018 -0800
@@ -130,6 +130,4 @@
    This has no topic and ends with a period.
   7: don't add trailing period on summary line
    This has no topic and ends with a period.
-  20: adds a function with foo_bar naming
-   + def blah_blah(x):
   [1]