# HG changeset patch # User Siddharth Agarwal # Date 1447883548 28800 # Node ID 28ee7af4b685a39279e6aff2a5d652adc3265577 # Parent 8be0af32e5134af59057c0432f5e756608fe5d4e filemerge: return whether the file is deleted for nomerge internal tools We're going to support the filemerge code resolving change/delete conflicts in upcoming patches. Some of these resolutions require that the dirstate be modified. Modifying the dirstate directly from in here would be (a) a pretty bad layering violation and (b) wrong because all dirstate removals should happen before adds. So in this and upcoming patches we're instead going to pass whether the file is deleted up to merge.mergestate, then in there figure out what dirstate action needs to be taken. diff -r 8be0af32e513 -r 28ee7af4b685 mercurial/filemerge.py --- a/mercurial/filemerge.py Wed Nov 18 15:46:45 2015 -0800 +++ b/mercurial/filemerge.py Wed Nov 18 13:52:28 2015 -0800 @@ -232,18 +232,18 @@ return _ilocal(repo, mynode, orig, fcd, fco, fca, toolconf) except error.ResponseExpected: ui.write("\n") - return 1 + return 1, False @internaltool('local', nomerge) def _ilocal(repo, mynode, orig, fcd, fco, fca, toolconf): """Uses the local version of files as the merged version.""" - return 0 + return 0, False @internaltool('other', nomerge) def _iother(repo, mynode, orig, fcd, fco, fca, toolconf): """Uses the other version of files as the merged version.""" repo.wwrite(fcd.path(), fco.data(), fco.flags()) - return 0 + return 0, False @internaltool('fail', nomerge) def _ifail(repo, mynode, orig, fcd, fco, fca, toolconf): @@ -251,7 +251,7 @@ Rather than attempting to merge files that were modified on both branches, it marks them as unresolved. The resolve command must be used to resolve these conflicts.""" - return 1 + return 1, False def _premerge(repo, toolconf, files, labels=None): tool, toolpath, binary, symlink = toolconf @@ -536,7 +536,8 @@ toolconf = tool, toolpath, binary, symlink if mergetype == nomerge: - return True, func(repo, mynode, orig, fcd, fco, fca, toolconf) + r, deleted = func(repo, mynode, orig, fcd, fco, fca, toolconf) + return True, r if premerge: if orig != fco.path():