# HG changeset patch # User Pierre-Yves David # Date 1675355558 -3600 # Node ID 362d5a2ffd1739248d7140212f641d49264c1340 # Parent 0ec94359eae869b13ff46159db63f397c08c3092 safehasattr: pass attribute name as string instead of bytes This is a step toward replacing `util.safehasattr` usage with plain `hasattr`. The builtin function behave poorly in Python2 but this was fixed in Python3. These change are done one by one as they tend to have a small odd to trigger puzzling breackage. diff -r 0ec94359eae8 -r 362d5a2ffd17 mercurial/mdiff.py --- a/mercurial/mdiff.py Thu Feb 02 17:30:50 2023 +0100 +++ b/mercurial/mdiff.py Thu Feb 02 17:32:38 2023 +0100 @@ -213,7 +213,7 @@ if ( opts is None or not opts.xdiff - or not util.safehasattr(bdiff, b'xdiffblocks') + or not util.safehasattr(bdiff, 'xdiffblocks') ): return bdiff.blocks else: