# HG changeset patch # User Pierre-Yves David # Date 1567876127 25200 # Node ID 3bed541aa65da16ac0b0cb4dcf7e388f875a8ced # Parent 519b45603880b0b3dfca894c84884ca13b308fe5 flagprocessors: small code update to clarify parameters 'raw' is really a third mode, not a small variant. Differential Revision: https://phab.mercurial-scm.org/D6807 diff -r 519b45603880 -r 3bed541aa65d mercurial/revlogutils/flagutil.py --- a/mercurial/revlogutils/flagutil.py Sat Sep 07 10:06:32 2019 -0700 +++ b/mercurial/revlogutils/flagutil.py Sat Sep 07 10:08:47 2019 -0700 @@ -154,13 +154,13 @@ processed text and ``validatehash`` is a bool indicating whether the returned text should be checked for hash integrity. """ - return self._processflagsfunc(text, flags, 'read', raw=True)[1] + return self._processflagsfunc(text, flags, 'raw')[1] - def _processflagsfunc(self, text, flags, operation, raw=False): + def _processflagsfunc(self, text, flags, operation): # fast path: no flag processors will run if flags == 0: return text, True - if not operation in ('read', 'write'): + if operation not in ('read', 'write', 'raw'): raise error.ProgrammingError(_("invalid '%s' operation") % operation) # Check all flags are known. @@ -188,7 +188,7 @@ if processor is not None: readtransform, writetransform, rawtransform = processor - if raw: + if operation == 'raw': vhash = rawtransform(self, text) elif operation == 'read': text, vhash = readtransform(self, text)