# HG changeset patch # User Nicolas Dumazet # Date 1279604525 -32400 # Node ID 4da35e02b67cb02c75f1915ee90c6c37f0d62973 # Parent 09147c065711da84a620068eb75fe2ff714e2232 log: do not redefine cachefunc in walkchangerevs The same variable is defined a few blocks earlier. The first phases in walkchangerevs should in fact fill that cache, and allow faster lookups in the last phase. Redefining and overriding this cached function, (knowing that it will be called with the same arguments) defeats the caching purpose. diff -r 09147c065711 -r 4da35e02b67c mercurial/cmdutil.py --- a/mercurial/cmdutil.py Wed Jul 21 09:43:45 2010 +0200 +++ b/mercurial/cmdutil.py Tue Jul 20 14:42:05 2010 +0900 @@ -1182,7 +1182,6 @@ return rev in wanted for i, window in increasing_windows(0, len(revs)): - change = util.cachefunc(repo.changectx) nrevs = [rev for rev in revs[i:i + window] if want(rev)] for rev in sorted(nrevs): fns = fncache.get(rev)