# HG changeset patch # User Yuya Nishihara # Date 1501682318 -32400 # Node ID 6788e648efcfde237bca8fa22794c8fc5c64c502 # Parent b4793cc8e1c033416f7ded4807f69d5ad164b250 test-revlog-raw: close file handles explicitly (issue5644) diff -r b4793cc8e1c0 -r 6788e648efcf tests/test-revlog-raw.py --- a/tests/test-revlog-raw.py Wed Aug 02 22:04:02 2017 +0900 +++ b/tests/test-revlog-raw.py Wed Aug 02 22:58:38 2017 +0900 @@ -144,12 +144,18 @@ text = None cachedelta = (deltaparent, rlog.revdiff(deltaparent, r)) flags = rlog.flags(r) - ifh = dlog.opener(dlog.indexfile, 'a+') - dfh = None - if not dlog._inline: - dfh = dlog.opener(dlog.datafile, 'a+') - dlog._addrevision(rlog.node(r), text, tr, r, p1, p2, flags, cachedelta, - ifh, dfh) + ifh = dfh = None + try: + ifh = dlog.opener(dlog.indexfile, 'a+') + if not dlog._inline: + dfh = dlog.opener(dlog.datafile, 'a+') + dlog._addrevision(rlog.node(r), text, tr, r, p1, p2, flags, + cachedelta, ifh, dfh) + finally: + if dfh is not None: + dfh.close() + if ifh is not None: + ifh.close() return dlog # Utilities to generate revisions for testing