# HG changeset patch # User FUJIWARA Katsunori # Date 1455111869 -32400 # Node ID 7e9e39228de6f37272d63802449fc4ffca91b980 # Parent c00f67c15c5ad63c656b96e0866f39df62756145 check-code: examine magic pattern matching against contents of a file Before this patch, check-code examines "magic" pattern (e.g. '^#!.*python') matching against not contents of a file, but name of it. This unintentionally omits code checking against Python source file, of which filename doesn't end with "*.py" or "*.cgi", even though contents of it starts with "#!/bin/python" or so. In this change, 'pre' refers contents of file 'f'. diff -r c00f67c15c5a -r 7e9e39228de6 contrib/check-code.py --- a/contrib/check-code.py Wed Feb 10 22:44:29 2016 +0900 +++ b/contrib/check-code.py Wed Feb 10 22:44:29 2016 +0900 @@ -485,7 +485,7 @@ if debug: print name, f fc = 0 - if not (re.match(match, f) or (magic and re.search(magic, f))): + if not (re.match(match, f) or (magic and re.search(magic, pre))): if debug: print "Skipping %s for %s it doesn't match %s" % ( name, match, f)