# HG changeset patch # User FUJIWARA Katsunori # Date 1399543380 -32400 # Node ID 7f7f634d073d8091b9cbd654bfb1d3f3338b1527 # Parent 2e91d4964ecdef6ae2914808c6b872dfabf5f339 subrepo: invoke "_sanitize()" also after "git merge --ff" Before this patch, sanitizing ".hg/hgrc" in git subrepo doesn't work, when the working directory is updated by "git merge --ff". "_sanitize()" is not invoked after checking target revision out into the working directory in this case, even though it is invoked indirectly via "checkout" (or "rawcheckout") in other cases. This patch invokes "_sanitize()" explicitly also after "git merge --ff" execution. diff -r 2e91d4964ecd -r 7f7f634d073d mercurial/subrepo.py --- a/mercurial/subrepo.py Thu May 08 19:03:00 2014 +0900 +++ b/mercurial/subrepo.py Thu May 08 19:03:00 2014 +0900 @@ -1392,6 +1392,7 @@ if tracking[remote] != self._gitcurrentbranch(): checkout([tracking[remote]]) self._gitcommand(['merge', '--ff', remote]) + _sanitize(self._ui, self._path) else: # a real merge would be required, just checkout the revision rawcheckout() diff -r 2e91d4964ecd -r 7f7f634d073d tests/test-subrepo-git.t --- a/tests/test-subrepo-git.t Thu May 08 19:03:00 2014 +0900 +++ b/tests/test-subrepo-git.t Thu May 08 19:03:00 2014 +0900 @@ -608,3 +608,52 @@ cat: s/sub/.hg/hgrc: No such file or directory [1] $ cd .. + +additional test for "git merge --ff" route: + + $ cd t + $ hg tip -q + 8:3473d20bddcf + $ hg update -q -C af6d2edbb0d3 + $ cd s + $ git checkout -q testing + $ mkdir .hg + $ echo '.hg/hgrc in git repo' > .hg/hgrc + $ mkdir -p sub/.hg + $ echo 'sub/.hg/hgrc in git repo' > sub/.hg/hgrc + $ git add .hg sub + $ git commit -qm 'add .hg/hgrc to be sanitized at hg update (git merge --ff)' + $ git push -q origin testing + $ cd .. + $ grep ' s$' .hgsubstate + 32a343883b74769118bb1d3b4b1fbf9156f4dddc s + $ hg commit -qm 'commit with git revision including .hg/hgrc' + $ hg parents -q + 9:ed23f7fe024e + $ grep ' s$' .hgsubstate + f262643c1077219fbd3858d54e78ef050ef84fbf s + $ cd .. + + $ cd tc + $ hg update -q -C af6d2edbb0d3 + $ cat s/.hg/hgrc + cat: s/.hg/hgrc: No such file or directory + [1] + $ cat s/sub/.hg/hgrc + cat: s/sub/.hg/hgrc: No such file or directory + [1] + $ hg pull -q + $ hg update -q -C ed23f7fe024e 2>&1 | sort + warning: removing potentially hostile 'hgrc' in 's/.hg' (glob) + warning: removing potentially hostile 'hgrc' in 's/sub/.hg' (glob) + $ hg parents -q + 9:ed23f7fe024e + $ grep ' s$' .hgsubstate + f262643c1077219fbd3858d54e78ef050ef84fbf s + $ cat s/.hg/hgrc + cat: s/.hg/hgrc: No such file or directory + [1] + $ cat s/sub/.hg/hgrc + cat: s/sub/.hg/hgrc: No such file or directory + [1] + $ cd ..