# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@fb.com>
# Date 1415212299 0
# Node ID a4af6fd99fb0c9c2b7bf9bc2b5a88343a0c52dc9
# Parent  a7f25a31e02188e0c5193cbafb1902d9d53cb987
mail: actually use the verifycert config value

The mail module only verifies the smtp ssl certificate if 'verifycert' is enabled
(the default). The 'verifycert' can take three possible values:

- 'strict'
- 'loose'
- any "False" value, eg: 'false' or '0'

We tested the validity of the third value, but never converted it to actual
falseness, making 'False' an equivalent for 'loose'.

This changeset fixes it.

diff -r a7f25a31e021 -r a4af6fd99fb0 mercurial/mail.py
--- a/mercurial/mail.py	Thu Nov 06 09:36:39 2014 +0100
+++ b/mercurial/mail.py	Wed Nov 05 18:31:39 2014 +0000
@@ -104,6 +104,7 @@
         if util.parsebool(verifycert) is not False:
             raise util.Abort(_('invalid smtp.verifycert configuration: %s')
                              % (verifycert))
+        verifycert = False
     if (starttls or smtps) and verifycert:
         sslkwargs = sslutil.sslkwargs(ui, mailhost)
     else: