# HG changeset patch # User Adrian Buehlmann # Date 1291993814 -3600 # Node ID a98a9002326150d3afe569404fa4fe309b73b1ad # Parent 039a964dbbb32e769b483b2184535d47bb003e4e localrepo: remove unneeded os.unlink call in wwrite The opener already unlinks the filename before 'w'riting, for both the symlink and the normal file case. It also now resets the flags for normal files on 'w'rite, which makes this os.unlink call completely redundant. For Windows, removing this extra unlink call helps to avoid tripping issue2524 (os.unlink followed by a write). diff -r 039a964dbbb3 -r a98a90023261 mercurial/localrepo.py --- a/mercurial/localrepo.py Fri Dec 10 15:14:05 2010 +0100 +++ b/mercurial/localrepo.py Fri Dec 10 16:10:14 2010 +0100 @@ -629,10 +629,6 @@ def wwrite(self, filename, data, flags): data = self._filter(self._decodefilterpats, filename, data) - try: - os.unlink(self.wjoin(filename)) - except OSError: - pass if 'l' in flags: self.wopener.symlink(data, filename) else: