# HG changeset patch # User Augie Fackler # Date 1422371224 18000 # Node ID c8e7fa41bfc53dc23fad0e977eb56a110370fccb # Parent df463ca0adefbf6ffa084cfd8031dcfc6c944f8e diffhelpers: verify hline was created before using it Found with cpychecker. diff -r df463ca0adef -r c8e7fa41bfc5 mercurial/diffhelpers.c --- a/mercurial/diffhelpers.c Sun Jan 25 22:55:10 2015 -0500 +++ b/mercurial/diffhelpers.c Tue Jan 27 10:07:04 2015 -0500 @@ -34,6 +34,9 @@ sz -= 1; hline = PyBytes_FromStringAndSize(l, sz-1); + if (!hline) { + return NULL; + } if (c == ' ' || c == '+') { PyObject *rline = PyBytes_FromStringAndSize(l + 1, sz - 2); @@ -194,4 +197,3 @@ NULL, NULL); } #endif -