upgrade: disable using the parallel workers optimization on macOS
authorMatt Harbison <matt_harbison@yahoo.com>
Wed, 09 Oct 2024 13:55:04 -0400
changeset 52035 028bac79cf34
parent 52034 e3952d8cfeb5
child 52036 989967d2f994
upgrade: disable using the parallel workers optimization on macOS It crashes `test-copies-chain-merge.t` for some reason[1]. It's only experimental, and already hard-disabled on Windows. [1] https://foss.heptapod.net/mercurial/mercurial-devel/-/jobs/2591045#L108
mercurial/upgrade_utils/engine.py
--- a/mercurial/upgrade_utils/engine.py	Sun Oct 13 04:55:48 2024 +0200
+++ b/mercurial/upgrade_utils/engine.py	Wed Oct 09 13:55:04 2024 -0400
@@ -31,6 +31,14 @@
 
 def get_sidedata_helpers(srcrepo, dstrepo):
     use_w = srcrepo.ui.configbool(b'experimental', b'worker.repository-upgrade')
+
+    if use_w and pycompat.isdarwin:
+        # Avoid a PicklingError on macOS in bundlerepository.
+        use_w = False
+        srcrepo.ui.debug(
+            b'ignoring experimental.worker.repository-upgrade=True on darwin'
+        )
+
     sequential = pycompat.iswindows or not use_w
     if not sequential:
         srcrepo.register_sidedata_computer(