changeset 23831:0ab23a48b9a7

hgweb: fix diffstat links in paper/changeset.tmpl '<a .../>foo</a>' syntax is incorrect, since the first tag just "tries" to close itself and then the actual content follows. It doesn't work, either because web browsers know better than this or because there should be a whitespace before /: '<a />'. So for the hgweb users the links looked normal anyway, but now they are correct in code as well.
author Anton Shestakov <engored@ya.ru>
date Sat, 10 Jan 2015 18:00:57 +0800
parents c4f6fc4eb01e
children 62f41f251e52
files mercurial/templates/paper/changeset.tmpl tests/test-hgweb-commands.t tests/test-hgweb-diffs.t tests/test-hgweb-removed.t
diffstat 4 files changed, 10 insertions(+), 10 deletions(-) [+]
line wrap: on
line diff
--- a/mercurial/templates/paper/changeset.tmpl	Sat Jan 10 17:54:24 2015 +0800
+++ b/mercurial/templates/paper/changeset.tmpl	Sat Jan 10 18:00:57 2015 +0800
@@ -65,9 +65,9 @@
   <th class="diffstat">diffstat</th>
   <td class="diffstat">
     {diffsummary}
-    <a id="diffstatexpand" href="javascript:toggleDiffstat()"/>[<tt>+</tt>]</a>
+    <a id="diffstatexpand" href="javascript:toggleDiffstat()">[<tt>+</tt>]</a>
     <div id="diffstatdetails" style="display:none;">
-      <a href="javascript:toggleDiffstat()"/>[<tt>-</tt>]</a>
+      <a href="javascript:toggleDiffstat()">[<tt>-</tt>]</a>
       <p></p>
       <table class="stripes2">{diffstat}</table>
     </div>
--- a/tests/test-hgweb-commands.t	Sat Jan 10 17:54:24 2015 +0800
+++ b/tests/test-hgweb-commands.t	Sat Jan 10 18:00:57 2015 +0800
@@ -891,9 +891,9 @@
     <td class="diffstat">
        2 files changed, 2 insertions(+), 0 deletions(-)
   
-      <a id="diffstatexpand" href="javascript:toggleDiffstat()"/>[<tt>+</tt>]</a>
+      <a id="diffstatexpand" href="javascript:toggleDiffstat()">[<tt>+</tt>]</a>
       <div id="diffstatdetails" style="display:none;">
-        <a href="javascript:toggleDiffstat()"/>[<tt>-</tt>]</a>
+        <a href="javascript:toggleDiffstat()">[<tt>-</tt>]</a>
         <p></p>
         <table class="stripes2">  <tr>
       <td class="diffstat-file"><a href="#l1.1">da/foo</a></td>
--- a/tests/test-hgweb-diffs.t	Sat Jan 10 17:54:24 2015 +0800
+++ b/tests/test-hgweb-diffs.t	Sat Jan 10 18:00:57 2015 +0800
@@ -115,9 +115,9 @@
     <td class="diffstat">
        2 files changed, 2 insertions(+), 0 deletions(-)
   
-      <a id="diffstatexpand" href="javascript:toggleDiffstat()"/>[<tt>+</tt>]</a>
+      <a id="diffstatexpand" href="javascript:toggleDiffstat()">[<tt>+</tt>]</a>
       <div id="diffstatdetails" style="display:none;">
-        <a href="javascript:toggleDiffstat()"/>[<tt>-</tt>]</a>
+        <a href="javascript:toggleDiffstat()">[<tt>-</tt>]</a>
         <p></p>
         <table class="stripes2">  <tr>
       <td class="diffstat-file"><a href="#l1.1">a</a></td>
@@ -387,9 +387,9 @@
     <td class="diffstat">
        2 files changed, 2 insertions(+), 0 deletions(-)
   
-      <a id="diffstatexpand" href="javascript:toggleDiffstat()"/>[<tt>+</tt>]</a>
+      <a id="diffstatexpand" href="javascript:toggleDiffstat()">[<tt>+</tt>]</a>
       <div id="diffstatdetails" style="display:none;">
-        <a href="javascript:toggleDiffstat()"/>[<tt>-</tt>]</a>
+        <a href="javascript:toggleDiffstat()">[<tt>-</tt>]</a>
         <p></p>
         <table class="stripes2">  <tr>
       <td class="diffstat-file"><a href="#l1.1">a</a></td>
--- a/tests/test-hgweb-removed.t	Sat Jan 10 17:54:24 2015 +0800
+++ b/tests/test-hgweb-removed.t	Sat Jan 10 18:00:57 2015 +0800
@@ -96,9 +96,9 @@
     <td class="diffstat">
        1 files changed, 0 insertions(+), 1 deletions(-)
   
-      <a id="diffstatexpand" href="javascript:toggleDiffstat()"/>[<tt>+</tt>]</a>
+      <a id="diffstatexpand" href="javascript:toggleDiffstat()">[<tt>+</tt>]</a>
       <div id="diffstatdetails" style="display:none;">
-        <a href="javascript:toggleDiffstat()"/>[<tt>-</tt>]</a>
+        <a href="javascript:toggleDiffstat()">[<tt>-</tt>]</a>
         <p></p>
         <table class="stripes2">  <tr>
       <td class="diffstat-file"><a href="#l1.1">a</a></td>