[RFC] convert: fix --datesort
authorKirill Smelkov <kirr@mns.spb.ru>
Tue, 18 Dec 2007 14:01:34 -0600
changeset 6099 37cc79a5727a
parent 6098 65340b8231eb
child 6100 49c69e1e4aa2
[RFC] convert: fix --datesort The problem is that previously commit.date was used for sorting, but it's a string like "1 Jan xxx 2007", so it it wrong to use it for sorting. Another problem is that why we are using depth for sorting -- I have no clear answer -- it seems to be plain wrong. This patch is just an RFC.
hgext/convert/convcmd.py
--- a/hgext/convert/convcmd.py	Fri Feb 15 15:44:32 2008 -0200
+++ b/hgext/convert/convcmd.py	Tue Dec 18 14:01:34 2007 -0600
@@ -157,7 +157,8 @@
                 if pl:
                     depth[n] = max([depth[p] for p in pl]) + 1
 
-            s = [(depth[n], self.commitcache[n].date, n) for n in s]
+            s = [(depth[n], util.parsedate(self.commitcache[n].date), n)
+                 for n in s]
             s.sort()
             s = [e[2] for e in s]