run-tests: partially backout PYTHON quoting
authorMatt Harbison <matt_harbison@yahoo.com>
Thu, 20 Sep 2018 23:45:30 -0400
changeset 39758 38d51371792b
parent 39757 7303ab86431a
child 39759 f803bcb902ad
run-tests: partially backout PYTHON quoting In 7f8b7a060584, I quoted this to support python being installed to "Program Files". Even though the string passed to os.popen() is this: "c:/Python27/python.exe" -c "import mercurial; print (mercurial.__path__[0])" ... cmd.exe is trying to run this: 'c:/Python27/python.exe" -c "import' This caused test-hghave.t to fail, reporting 'unexpected mercurial lib: ""', because the failed execution prints nothing to stdout. Py3 fails as though it's not quoted. For whatever reason, print() shows up in the output when run with py2, but not py3, so I'm having a hard time debugging this. For now, let's fix the buildbot.
tests/run-tests.py
--- a/tests/run-tests.py	Fri Sep 21 03:16:08 2018 +0530
+++ b/tests/run-tests.py	Thu Sep 20 23:45:30 2018 -0400
@@ -3082,7 +3082,7 @@
         if self._hgpath is not None:
             return self._hgpath
 
-        cmd = b'"%s" -c "import mercurial; print (mercurial.__path__[0])"'
+        cmd = b'%s -c "import mercurial; print (mercurial.__path__[0])"'
         cmd = cmd % PYTHON
         if PYTHON3:
             cmd = _strpath(cmd)