--- a/contrib/check-code.py Sun Feb 07 01:52:10 2010 +0100
+++ b/contrib/check-code.py Sun Feb 07 10:58:51 2010 +0100
@@ -33,17 +33,17 @@
testpats = [
- (r'(pushd|popd)', "don't use pushd|popd, use cd"),
- (r'\W\$?\(\([^\)]*\)\)', "don't use (()) or $(()), use expr"),
+ (r'(pushd|popd)', "don't use 'pushd' or 'popd', use 'cd'"),
+ (r'\W\$?\(\([^\)]*\)\)', "don't use (()) or $(()), use 'expr'"),
(r'^function', "don't use 'function', use old style"),
- (r'grep.*-q', "don't use grep -q, redirect to /dev/null"),
+ (r'grep.*-q', "don't use 'grep -q', redirect to /dev/null"),
(r'echo.*\\n', "don't use 'echo \\n', use printf"),
- (r'^diff.*-\w*N', "don't use diff -N"),
+ (r'^diff.*-\w*N', "don't use 'diff -N'"),
(r'(^| )wc[^|]*$', "filter wc output"),
- (r'head -c', "don't use head -c, use dd"),
- (r'ls.*-\w*R', "don't use ls -R, use find"),
- (r'printf.*\\\d\d\d', "don't use printf \NNN, use python"),
- (r'printf.*\\x', "don't use printf \\x, use python"),
+ (r'head -c', "don't use 'head -c', use 'dd'"),
+ (r'ls.*-\w*R', "don't use 'ls -R', use 'find'"),
+ (r'printf.*\\\d\d\d', "don't use 'printf \NNN', use Python"),
+ (r'printf.*\\x', "don't use printf \\x, use Python"),
(r'\$\(.*\)', "don't use $(expr), use `expr`"),
(r'rm -rf \*', "don't use naked rm -rf, target a directory"),
(r'(^|\|\s*)grep (-\w\s+)*[^|]*[(|]\w',