Mercurial > hg-stable
changeset 34396:41401f502c83
tests: disable lints on mercurial/thirdparty
In the next patch, this directory will be used to vendor in some third-party
code.
Differential Revision: https://phab.mercurial-scm.org/D866
| author | Siddharth Agarwal <sid0@fb.com> |
|---|---|
| date | Sun, 01 Oct 2017 03:24:19 -0700 |
| parents | dbf83230e8be |
| children | 9fb9f8440b71 |
| files | contrib/import-checker.py tests/test-check-code.t tests/test-check-module-imports.t tests/test-check-pylint.t |
| diffstat | 4 files changed, 9 insertions(+), 3 deletions(-) [+] |
line wrap: on
line diff
--- a/contrib/import-checker.py Sun Oct 01 03:48:28 2017 -0700 +++ b/contrib/import-checker.py Sun Oct 01 03:24:19 2017 -0700 @@ -35,6 +35,8 @@ 'mercurial.pure.mpatch', 'mercurial.pure.osutil', 'mercurial.pure.parsers', + # third-party imports should be directly imported + 'mercurial.thirdparty', ) # Whitelist of symbols that can be directly imported.
--- a/tests/test-check-code.t Sun Oct 01 03:48:28 2017 -0700 +++ b/tests/test-check-code.t Sun Oct 01 03:24:19 2017 -0700 @@ -7,9 +7,11 @@ New errors are not allowed. Warnings are strongly discouraged. (The writing "no-che?k-code" is for not skipping this file when checking.) - $ testrepohg locate -X contrib/python-zstandard \ - > -X hgext/fsmonitor/pywatchman | - > sed 's-\\-/-g' | "$check_code" --warnings --per-file=0 - || false + $ testrepohg locate \ + > -X contrib/python-zstandard \ + > -X hgext/fsmonitor/pywatchman \ + > -X mercurial/thirdparty \ + > | sed 's-\\-/-g' | "$check_code" --warnings --per-file=0 - || false Skipping i18n/polib.py it has no-che?k-code (glob) Skipping mercurial/httpclient/__init__.py it has no-che?k-code (glob) Skipping mercurial/httpclient/_readers.py it has no-che?k-code (glob)
--- a/tests/test-check-module-imports.t Sun Oct 01 03:48:28 2017 -0700 +++ b/tests/test-check-module-imports.t Sun Oct 01 03:24:19 2017 -0700 @@ -25,6 +25,7 @@ > -X doc/gendoc.py \ > -X doc/hgmanpage.py \ > -X i18n/posplit \ + > -X mercurial/thirdparty \ > -X tests/hypothesishelpers.py \ > -X tests/test-commit-interactive.t \ > -X tests/test-contrib-check-code.t \
--- a/tests/test-check-pylint.t Sun Oct 01 03:48:28 2017 -0700 +++ b/tests/test-check-pylint.t Sun Oct 01 03:24:19 2017 -0700 @@ -12,6 +12,7 @@ $ touch $TESTTMP/fakerc $ pylint --rcfile=$TESTTMP/fakerc --disable=all \ > --enable=W0102 --reports=no \ + > --ignore=thirdparty \ > mercurial hgdemandimport hgext hgext3rd (?) ------------------------------------ (?)