Mercurial > hg-stable

changeset 30006:599912a62ff6

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
transaction: open a file with checkambig=True to avoid file stat ambiguity Before this patch, if steps below occurs at "the same time in sec", all of mtime, ctime and size are same between (1) and (3). 1. append data to revlog-style file (and close transaction) 2. discard appended data by truncation of rollback 3. append same size but different data to revlog-style file again Therefore, cache validation doesn't work after (3) as expected. To avoid file stat ambiguity around truncation, this patch opens a file with checkambig=True. This is a part of ExactCacheValidationPlan. https://www.mercurial-scm.org/wiki/ExactCacheValidationPlan
author FUJIWARA Katsunori <foozy@lares.dti.ne.jp>
date Thu, 22 Sep 2016 21:52:00 +0900
parents e38d85be978f
children 46825334f270
files mercurial/transaction.py
diffstat 1 files changed, 1 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/mercurial/transaction.py	Thu Sep 22 21:52:00 2016 +0900
+++ b/mercurial/transaction.py	Thu Sep 22 21:52:00 2016 +0900
@@ -48,7 +48,7 @@
     for f, o, _ignore in entries:
         if o or not unlink:
             try:
-                fp = opener(f, 'a')
+                fp = opener(f, 'a', checkambig=True)
                 fp.truncate(o)
                 fp.close()
             except IOError: