changeset 47784:59bc92a7c60f stable

store: document the decoding discrepancy in store.py This will help future people that might be looking into this. Differential Revision: https://phab.mercurial-scm.org/D11220
author Pierre-Yves David <pierre-yves.david@octobus.net>
date Tue, 27 Jul 2021 19:36:20 +0200
parents 17211649bac2
children 324c8a299324
files mercurial/store.py
diffstat 1 files changed, 5 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/mercurial/store.py	Tue Jul 27 19:19:00 2021 +0200
+++ b/mercurial/store.py	Tue Jul 27 19:36:20 2021 +0200
@@ -569,6 +569,11 @@
         self.vfs = vfsmod.filtervfs(vfs, encodefilename)
         self.opener = self.vfs
 
+    # note: topfiles would also need a decode phase. It is just that in
+    # practice we do not have any file outside of `data/` that needs encoding.
+    # However that might change so we should probably add a test and encoding
+    # decoding for it too. see issue6548
+
     def datafiles(self, matcher=None):
         for t, a, b, size in super(encodedstore, self).datafiles():
             try: