Mercurial > hg-stable

changeset 51719:5ad5f0853a0a stable

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
wireprototypes: fix exception handling code with a bad pytype suppression This goes back to f5fcf7123a92, and I suspect it was a misread of the error message is describes- the LHS of `.sorted()` is always bytes, and bytes didn't have this method in py2 either. The invalid names were already handled like this a few lines above. PyCharm flagged this, and it stood out after converting the zope interfaces to Protocol classes (which hasn't been published yet).
author Matt Harbison <matt_harbison@yahoo.com>
date Thu, 24 Oct 2024 22:55:45 -0400
parents 71044315a536
children 49aeeda97c14
files mercurial/wireprototypes.py
diffstat 1 files changed, 1 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/mercurial/wireprototypes.py	Thu Jan 11 20:37:34 2024 +0100
+++ b/mercurial/wireprototypes.py	Thu Oct 24 22:55:45 2024 -0400
@@ -396,7 +396,7 @@
             )
             % config,
             hint=_(b'usable compression engines: %s')
-            % b', '.sorted(validnames),  # pytype: disable=attribute-error
+            % b', '.join(sorted(validnames)),
         )
 
     return compengines