Mercurial Mercurial > hg-stable / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
ui: simplify geteditor
authorJun Wu <quark@fb.com>
Sun, 26 Mar 2017 21:41:42 -0700
changeset 31692 5bea95a1d353
parent 31691 fbc4eb8e2433
child 31693 c5fe0c7dad94
ui: simplify geteditor Now $EDITOR and $VISUAL will affect ui.editor directly. So it's no longer necessary to test them in ui.geteditor.
mercurial/ui.py file | annotate | diff | comparison | revisions 
--- a/mercurial/ui.py	Sun Mar 26 21:40:22 2017 -0700
+++ b/mercurial/ui.py	Sun Mar 26 21:41:42 2017 -0700
@@ -1326,9 +1326,7 @@
         else:
             editor = 'vi'
         return (encoding.environ.get("HGEDITOR") or
-                self.config("ui", "editor") or
-                encoding.environ.get("VISUAL") or
-                encoding.environ.get("EDITOR", editor))
+                self.config("ui", "editor", editor))
 
     @util.propertycache
     def _progbar(self):
hg-stable