changeset 33367:6029939f7e98

filterpyflakes: move self-test into test file This will avoid a false positive on an upcoming check-code rule. Differential Revision: https://phab.mercurial-scm.org/D18
author Augie Fackler <raf@durin42.com>
date Fri, 07 Jul 2017 15:07:36 -0400
parents 062c1bde1781
children ffb30661f672
files tests/filterpyflakes.py tests/test-check-pyflakes.t
diffstat 2 files changed, 7 insertions(+), 5 deletions(-) [+]
line wrap: on
line diff
--- a/tests/filterpyflakes.py	Sun Jul 09 16:38:04 2017 -0400
+++ b/tests/filterpyflakes.py	Fri Jul 07 15:07:36 2017 -0400
@@ -35,7 +35,3 @@
 for line in lines:
     sys.stdout.write(line)
 print()
-
-# self test of "undefined name" detection
-if False:
-    print(undefinedname)
--- a/tests/test-check-pyflakes.t	Sun Jul 09 16:38:04 2017 -0400
+++ b/tests/test-check-pyflakes.t	Fri Jul 07 15:07:36 2017 -0400
@@ -6,10 +6,16 @@
 run pyflakes on all tracked files ending in .py or without a file ending
 (skipping binary file random-seed)
 
+  $ cat > test.py <<EOF
+  > print(undefinedname)
+  > EOF
+  $ pyflakes test.py 2>/dev/null | "$TESTDIR/filterpyflakes.py"
+  test.py:1: undefined name 'undefinedname'
+  
+
   $ testrepohg locate 'set:**.py or grep("^#!.*python")' \
   > -X hgext/fsmonitor/pywatchman \
   > -X mercurial/pycompat.py -X contrib/python-zstandard \
   > 2>/dev/null \
   > | xargs pyflakes 2>/dev/null | "$TESTDIR/filterpyflakes.py"
-  tests/filterpyflakes.py:41: undefined name 'undefinedname'