pycompat: allow pycompat.sysbytes() even if input already is bytes
authorMartin von Zweigbergk <martinvonz@google.com>
Thu, 12 Dec 2019 10:26:09 -0800
changeset 43876 66af68d4c751
parent 43875 cf065c6a0197
child 43877 1390bb81163e
pycompat: allow pycompat.sysbytes() even if input already is bytes pycompat.sysstr() on py3 accepts an input that's already str (i.e. unicode). This patch makes it so pycompat.sysbytes() on py3 accepts an input that's already bytes. Allowing that makes it possible to do pycompat.sysbytes(fp.name) where fp.name is either bytes or unicode, as we'll get when fp can come from either open() or resources.open_binary(). Differential Revision: https://phab.mercurial-scm.org/D7621
mercurial/pycompat.py
--- a/mercurial/pycompat.py	Fri Dec 13 10:10:40 2019 -0800
+++ b/mercurial/pycompat.py	Thu Dec 12 10:26:09 2019 -0800
@@ -253,6 +253,8 @@
         This never raises UnicodeEncodeError, but only ASCII characters
         can be round-trip by sysstr(sysbytes(s)).
         """
+        if isinstance(s, bytes):
+            return s
         return s.encode('utf-8')
 
     def sysstr(s):