check-code: reject import urllib
authortimeless <timeless@mozdev.org>
Thu, 07 Apr 2016 00:34:07 +0000
changeset 28884 75309badb485
parent 28883 032c4c2f802a
child 28885 d7e7b3dd44c8
check-code: reject import urllib
contrib/check-code.py
--- a/contrib/check-code.py	Wed Apr 06 23:22:12 2016 +0000
+++ b/contrib/check-code.py	Thu Apr 07 00:34:07 2016 +0000
@@ -316,6 +316,8 @@
     (r'def.*[( ]\w+=\{\}', "don't use mutable default arguments"),
     (r'\butil\.Abort\b', "directly use error.Abort"),
     (r'^import Queue', "don't use Queue, use util.queue + util.empty"),
+    (r'^import cStringIO', "don't use cStringIO.StringIO, use util.stringio"),
+    (r'^import urllib', "don't use urllib, use util.urlreq/util.urlerr"),
   ],
   # warnings
   [