Mercurial Mercurial > hg-stable / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
metadataonlyctx: replace "changeset()[0]" to "manifestnode()"
authorJun Wu <quark@fb.com>
Fri, 07 Apr 2017 11:02:43 -0700
changeset 31840 7973e0a15bd4
parent 31839 5b048d5f8884
child 31841 9ff5a124d111
metadataonlyctx: replace "changeset()[0]" to "manifestnode()" As Yuya pointed out [1], "changeset()[0]" could be simplified to "manifestnode()". I didn't notice that method earlier. It should definitely be used - it's easier to read, and faster. [1]: https://www.mercurial-scm.org/pipermail/mercurial-devel/2017-March/095716.html
mercurial/context.py file | annotate | diff | comparison | revisions 
--- a/mercurial/context.py	Fri Apr 07 11:09:54 2017 -0700
+++ b/mercurial/context.py	Fri Apr 07 11:02:43 2017 -0700
@@ -2054,10 +2054,10 @@
         # sanity check to ensure that the reused manifest parents are
         # manifests of our commit parents
         mp1, mp2 = self.manifestctx().parents
-        if p1 != nullid and p1.changeset()[0] != mp1:
+        if p1 != nullid and p1.manifestnode() != mp1:
             raise RuntimeError('can\'t reuse the manifest: '
                                'its p1 doesn\'t match the new ctx p1')
-        if p2 != nullid and p2.changeset()[0] != mp2:
+        if p2 != nullid and p2.manifestnode() != mp2:
             raise RuntimeError('can\'t reuse the manifest: '
                                'its p2 doesn\'t match the new ctx p2')
hg-stable