changeset 31402:8b6927eb7efd

util: don't use mutable default argument value I don't think this is any tight loops and we'd need to worry about PyObject creation overhead. Also, I'm pretty sure strptime() will be much slower than PyObject creation (date parsing is surprisingly slow).
author Gregory Szorc <gregory.szorc@gmail.com>
date Sun, 12 Mar 2017 21:54:32 -0700
parents 6168d4b93634
children fd3d8eb7f545
files mercurial/util.py
diffstat 1 files changed, 3 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/mercurial/util.py	Sun Mar 12 21:53:03 2017 -0700
+++ b/mercurial/util.py	Sun Mar 12 21:54:32 2017 -0700
@@ -1827,9 +1827,11 @@
 
     return None, s
 
-def strdate(string, format, defaults=[]):
+def strdate(string, format, defaults=None):
     """parse a localized time string and return a (unixtime, offset) tuple.
     if the string cannot be parsed, ValueError is raised."""
+    defaults = defaults or []
+
     # NOTE: unixtime = localunixtime + offset
     offset, date = parsetimezone(string)