Mercurial > hg-stable
changeset 27417:9073a1e457c9
export: remove useless comparison between file object and string
It was introduced at 31aa2e5b0750, where "template" argument could be a file
object. After that, a306837f8c87 added "len(template)", so "template" must be
a string now. Therefore, "fp != template" should always be True.
It seems 31aa2e5b0750 was intended to work around a bug in TortoiseHg, and
I'm sure I've fixed it completely in TortoiseHg source.
https://selenic.com/pipermail/mercurial-devel/2011-February/028467.html
| author | Yuya Nishihara <yuya@tcha.org> |
|---|---|
| date | Sun, 13 Dec 2015 19:57:54 +0900 |
| parents | 9d04b4da6773 |
| children | 2ce4661ac226 |
| files | mercurial/cmdutil.py |
| diffstat | 1 files changed, 1 insertions(+), 2 deletions(-) [+] |
line wrap: on
line diff
--- a/mercurial/cmdutil.py Sun Dec 13 19:47:46 2015 +0900 +++ b/mercurial/cmdutil.py Sun Dec 13 19:57:54 2015 +0900 @@ -1054,8 +1054,7 @@ fp = makefileobj(repo, template, node, desc=desc, total=total, seqno=seqno, revwidth=revwidth, mode='wb', modemap=filemode) - if fp != template: - shouldclose = True + shouldclose = True if fp and not getattr(fp, 'name', '<unnamed>').startswith('<'): repo.ui.note("%s\n" % fp.name)