contrib: widen the "don't use `python`" net a little
authorAugie Fackler <augie@google.com>
Tue, 20 Jun 2017 17:25:57 -0400
changeset 33285 98f6c25aaf61
parent 33284 b2670290eab4
child 33286 2428e8ec0793
contrib: widen the "don't use `python`" net a little I'm still cleaning this up, but it's easier to do in bite-size chunks like this than all at once. The negative lookahead avoids one false positive category from some output related to finding Subversion bindings. Differential Revision: https://phab.mercurial-scm.org/D13
contrib/check-code.py
--- a/contrib/check-code.py	Wed Jul 05 13:54:53 2017 +0200
+++ b/contrib/check-code.py	Tue Jun 20 17:25:57 2017 -0400
@@ -138,7 +138,7 @@
      "put a backslash-escaped newline after sed 'i' command"),
     (r'^diff *-\w*[uU].*$\n(^  \$ |^$)', "prefix diff -u/-U with cmp"),
     (r'^\s+(if)? diff *-\w*[uU]', "prefix diff -u/-U with cmp"),
-    (r'python\s.+\.py', "don't use 'python', use '$PYTHON'"),
+    (r'\spython\s(?!bindings)', "don't use 'python', use '$PYTHON'"),
     (r'seq ', "don't use 'seq', use $TESTDIR/seq.py"),
     (r'\butil\.Abort\b', "directly use error.Abort"),
     (r'\|&', "don't use |&, use 2>&1"),