patchbomb: build patch texts by _getpatchmsgs()
authorYuya Nishihara <yuya@tcha.org>
Sat, 25 Feb 2017 18:28:04 +0900
changeset 31195 bbb5d2aa0bf0
parent 31194 e3ab7c717129
child 31196 83fa357edbd5
patchbomb: build patch texts by _getpatchmsgs() Now _getpatchmsgs() knows revision numbers, which allows us to generate flags by applying a template to changectx objects.
hgext/patchbomb.py
--- a/hgext/patchbomb.py	Sat Feb 25 18:25:17 2017 +0900
+++ b/hgext/patchbomb.py	Sat Feb 25 18:28:04 2017 +0900
@@ -340,7 +340,7 @@
                                      opts.get('test'))
     return (msg, subj, diffstat)
 
-def _getpatchmsgs(repo, sender, patches, patchnames=None, **opts):
+def _getpatchmsgs(repo, sender, revs, patchnames=None, **opts):
     """return a list of emails from a list of patches
 
     This involves introduction message creation if necessary.
@@ -349,6 +349,7 @@
     """
     ui = repo.ui
     _charsets = mail._charsets(ui)
+    patches = list(_getpatches(repo, revs, **opts))
     msgs = []
 
     ui.write(_('this patch series consists of %d patches.\n\n')
@@ -597,8 +598,7 @@
         bundleopts.pop('bundle', None)  # already processed
         msgs = _getbundlemsgs(repo, sender, bundledata, **bundleopts)
     else:
-        _patches = list(_getpatches(repo, revs, **opts))
-        msgs = _getpatchmsgs(repo, sender, _patches, **opts)
+        msgs = _getpatchmsgs(repo, sender, revs, **opts)
 
     showaddrs = []