repoview: fix conditional around unserved changesets
The conditional could lead to wrong computation since we have more unserved
changesets than just the "secret" phase.
In addition, now that we have efficient caching of phased changesets, we don't
need the conditional anymore.
--- a/mercurial/repoview.py Fri Apr 05 16:05:20 2019 +0300
+++ b/mercurial/repoview.py Sat Apr 13 20:57:50 2019 +0200
@@ -93,8 +93,8 @@
assert not repo.changelog.filteredrevs
# fast path in simple case to avoid impact of non optimised code
hiddens = filterrevs(repo, 'visible')
- if phases.hassecret(repo):
- secrets = repo._phasecache.getrevset(repo, phases.remotehiddenphases)
+ secrets = repo._phasecache.getrevset(repo, phases.remotehiddenphases)
+ if secrets:
return frozenset(hiddens | frozenset(secrets))
else:
return hiddens