win32: remove uneeded usage of _STARTF_USESHOWWINDOW
authorAdrian Buehlmann <adrian@cadifra.com>
Mon, 25 Jun 2012 19:26:29 +0200
changeset 17051 c5ed575f3137
parent 17050 e780fb37168b
child 17052 1bd18c415eec
win32: remove uneeded usage of _STARTF_USESHOWWINDOW spawndetached() was the only user of _STARTF_USESHOWWINDOW and it creates the process with _CREATE_NO_WINDOW anyway. If the process has no window, then there is nothing to hide.
mercurial/win32.py
--- a/mercurial/win32.py	Mon Jun 25 19:11:29 2012 +0200
+++ b/mercurial/win32.py	Mon Jun 25 19:26:29 2012 +0200
@@ -98,7 +98,6 @@
                 ('dwThreadId', _DWORD)]
 
 _CREATE_NO_WINDOW = 0x08000000
-_STARTF_USESHOWWINDOW = 0x00000001
 _SW_HIDE = 0
 
 class _COORD(ctypes.Structure):
@@ -318,8 +317,6 @@
     # which makes really detached processes impossible.
     si = _STARTUPINFO()
     si.cb = ctypes.sizeof(_STARTUPINFO)
-    si.dwFlags = _STARTF_USESHOWWINDOW
-    si.wShowWindow = _SW_HIDE
 
     pi = _PROCESS_INFORMATION()