Mercurial > hg-stable
changeset 48519:cfb4f1dee978
pytype: stop excluding wireprotov2server.py
This fixes:
File "/mnt/c/Users/Matt/hg/mercurial/wireprotov2server.py", line 584, in _capabilitiesv2:
unsupported operand type(s) for item assignment: Set[bytes] [unsupported-operands]
No attribute '__setitem__' on Set[bytes]
File "/mnt/c/Users/Matt/hg/mercurial/wireprotov2server.py", line 611, in _capabilitiesv2:
No attribute 'append' on dict [attribute-error]
In Union[List[bytes], List[nothing], dict]
Called from (traceback):
line 543, in httpv2apidescriptor
Differential Revision: https://phab.mercurial-scm.org/D11919
| author | Matt Harbison <matt_harbison@yahoo.com> |
|---|---|
| date | Mon, 13 Dec 2021 16:42:36 -0500 |
| parents | dcdecec401ca |
| children | c1fe758c1530 |
| files | mercurial/wireprotov2server.py tests/test-check-pytype.t |
| diffstat | 2 files changed, 4 insertions(+), 2 deletions(-) [+] |
line wrap: on
line diff
--- a/mercurial/wireprotov2server.py Mon Dec 13 14:43:10 2021 -0500 +++ b/mercurial/wireprotov2server.py Mon Dec 13 16:42:36 2021 -0500 @@ -579,10 +579,12 @@ ): continue + # pytype: disable=unsupported-operands caps[b'commands'][command] = { b'args': args, b'permissions': [entry.permission], } + # pytype: enable=unsupported-operands if entry.extracapabilitiesfn: extracaps = entry.extracapabilitiesfn(repo, proto) @@ -608,7 +610,9 @@ if key in target: entry[key] = target[key] + # pytype: disable=attribute-error caps[b'redirect'][b'targets'].append(entry) + # pytype: enable=attribute-error return proto.addcapabilities(repo, caps)
--- a/tests/test-check-pytype.t Mon Dec 13 14:43:10 2021 -0500 +++ b/tests/test-check-pytype.t Mon Dec 13 16:42:36 2021 -0500 @@ -44,7 +44,6 @@ mercurial/wireprotoserver.py # line 253, in _availableapis: No attribute '__iter__' on Callable[[Any, Any], Any] [attribute-error] mercurial/wireprotov1peer.py # [attribute-error] mercurial/wireprotov1server.py # BUG?: BundleValueError handler accesses subclass's attrs -mercurial/wireprotov2server.py # [unsupported-operands], [attribute-error] TODO: use --no-cache on test server? Caching the files locally helps during development, but may be a hinderance for CI testing. @@ -85,7 +84,6 @@ > -x mercurial/wireprotoserver.py \ > -x mercurial/wireprotov1peer.py \ > -x mercurial/wireprotov1server.py \ - > -x mercurial/wireprotov2server.py \ > > $TESTTMP/pytype-output.txt || cat $TESTTMP/pytype-output.txt Only show the results on a failure, because the output on success is also