Mercurial > hg-stable
changeset 15282:d4addef0ec74
tests: don't use 'test -e'
On Solaris 10:
$ test -e f
test: argument expected
| author | Mads Kiilerich <mads@kiilerich.com> |
|---|---|
| date | Mon, 17 Oct 2011 00:11:56 +0200 |
| parents | 2889d4574726 |
| children | 748715a380bc 872f06c342ff |
| files | contrib/check-code.py tests/test-subrepo-svn.t |
| diffstat | 2 files changed, 2 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/contrib/check-code.py Sat Oct 15 14:19:24 2011 -0500 +++ b/contrib/check-code.py Mon Oct 17 00:11:56 2011 +0200 @@ -69,6 +69,7 @@ (r'ls\s+[^|-]+\s+-', "options to 'ls' must come before filenames"), (r'[^>]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"), (r'stop\(\)', "don't use 'stop' as a shell function name"), + (r'(\[|\btest\b).*-e ', "don't use 'test -e', use 'test -f'"), ], # warnings []
--- a/tests/test-subrepo-svn.t Sat Oct 15 14:19:24 2011 -0500 +++ b/tests/test-subrepo-svn.t Mon Oct 17 00:11:56 2011 +0200 @@ -581,5 +581,5 @@ A $TESTTMP/rebaserepo/recreated/somethingold Checked out revision 10. 1 files updated, 0 files merged, 0 files removed, 0 files unresolved - $ test -e recreated/somethingold + $ test -f recreated/somethingold