typing: disable an attribute-error warning in the journal extension
authorMatt Harbison <matt_harbison@yahoo.com>
Thu, 05 Jan 2023 17:45:25 -0500
changeset 49942 d5116e4dc744
parent 49941 8b369bcbadf1
child 49943 ffeeaeb2d142
typing: disable an attribute-error warning in the journal extension The code is complicated enough that pytype doesn't realize that `name` can't be `None` if it is evaluated here.
hgext/journal.py
--- a/hgext/journal.py	Fri Jan 06 12:20:09 2023 -0500
+++ b/hgext/journal.py	Thu Jan 05 17:45:25 2023 -0500
@@ -567,8 +567,12 @@
         )
         fm.write(b'newnodes', b'%s', formatnodes(entry.newhashes))
         fm.condwrite(ui.verbose, b'user', b' %-8s', entry.user)
+
+        # ``name`` is bytes, or None only if 'all' was an option.
         fm.condwrite(
+            # pytype: disable=attribute-error
             opts.get(b'all') or name.startswith(b're:'),
+            # pytype: enable=attribute-error
             b'name',
             b'  %-8s',
             entry.name,