Mercurial > hg-stable
changeset 34319:d64c2c050b54
progress: demonstrate non-linear progress has a bad ETA experience
Previously, the ETA and speed assumes the progress is linear. Often, due to
network or other issues, it could be fast for the most time, and suddenly
slow down:
[====================================================> ]
\___________________________________________/\______/
very fast suddenly much slower
This patch adds a test demonstrating the ETA could be way off in those
cases.
Differential Revision: https://phab.mercurial-scm.org/D819
| author | Jun Wu <quark@fb.com> |
|---|---|
| date | Tue, 26 Sep 2017 12:48:15 -0700 |
| parents | 1826d695ad58 |
| children | f428c347d32b |
| files | tests/test-progress.t |
| diffstat | 1 files changed, 30 insertions(+), 3 deletions(-) [+] |
line wrap: on
line diff
--- a/tests/test-progress.t Thu Sep 21 15:58:44 2017 +0530 +++ b/tests/test-progress.t Tue Sep 26 12:48:15 2017 -0700 @@ -192,13 +192,15 @@ > class mocktime(object): > def __init__(self, increment): > self.time = 0 - > self.increment = increment + > self.increment = [int(s) for s in increment.split()] + > self.pos = 0 > def __call__(self): - > self.time += self.increment + > self.time += self.increment[self.pos % len(self.increment)] + > self.pos += 1 > return self.time > > def uisetup(ui): - > time.time = mocktime(int(os.environ.get('MOCKTIME', '11'))) + > time.time = mocktime(os.environ.get('MOCKTIME', '11')) > EOF $ cp $HGRCPATH.orig $HGRCPATH @@ -246,6 +248,31 @@ loop [=============================> ] 3/4 23w02d\r (no-eol) (esc) \r (no-eol) (esc) +Non-linear progress: + + $ MOCKTIME='20 20 20 20 20 20 20 20 20 20 500 500 500 500 500 20 20 20 20 20' hg -y loop 20 + \r (no-eol) (esc) + loop [=> ] 1/20 6m21s\r (no-eol) (esc) + loop [===> ] 2/20 6m01s\r (no-eol) (esc) + loop [=====> ] 3/20 5m41s\r (no-eol) (esc) + loop [=======> ] 4/20 5m21s\r (no-eol) (esc) + loop [=========> ] 5/20 5m01s\r (no-eol) (esc) + loop [===========> ] 6/20 4m41s\r (no-eol) (esc) + loop [=============> ] 7/20 4m21s\r (no-eol) (esc) + loop [===============> ] 8/20 4m01s\r (no-eol) (esc) + loop [================> ] 9/20 13m27s\r (no-eol) (esc) + loop [==================> ] 10/20 19m21s\r (no-eol) (esc) + loop [====================> ] 11/20 22m39s\r (no-eol) (esc) + loop [======================> ] 12/20 24m01s\r (no-eol) (esc) + loop [========================> ] 13/20 23m53s\r (no-eol) (esc) + loop [==========================> ] 14/20 19m09s\r (no-eol) (esc) + loop [============================> ] 15/20 15m01s\r (no-eol) (esc) + loop [==============================> ] 16/20 11m21s\r (no-eol) (esc) + loop [=================================> ] 17/20 8m04s\r (no-eol) (esc) + loop [===================================> ] 18/20 5m07s\r (no-eol) (esc) + loop [=====================================> ] 19/20 2m27s\r (no-eol) (esc) + \r (no-eol) (esc) + Time estimates should not fail when there's no end point: $ hg -y loop -- -4 \r (no-eol) (esc)