wireprotoserver: remove support for do_<command> handlers (API)
authorGregory Szorc <gregory.szorc@gmail.com>
Wed, 31 Jan 2018 11:17:41 -0800
changeset 35907 d7cce6df65bb
parent 35906 d747cf39cf70
child 35908 5a9ff8c20123
wireprotoserver: remove support for do_<command> handlers (API) Old versions of wire protocol handlers relied on methods named do_<command> to handle wire protocol commands. The last definition of these methods on sshserver was removed by 9f6e0e7ef828 ~2 years ago. I think it's time to not support this mechanism for defining command handlers. .. api:: sshserver no longers looks for wire protocol command handlers in methods named do_<command>. Use @wireproto.wireprotocommand to declare wire protocol command handler functions. Differential Revision: https://phab.mercurial-scm.org/D1985
mercurial/wireprotoserver.py
--- a/mercurial/wireprotoserver.py	Wed Jan 31 10:19:08 2018 -0800
+++ b/mercurial/wireprotoserver.py	Wed Jan 31 11:17:41 2018 -0800
@@ -344,13 +344,7 @@
             rsp = wireproto.dispatch(self.repo, self, cmd)
             self.handlers[rsp.__class__](self, rsp)
         elif cmd:
-            impl = getattr(self, 'do_' + cmd, None)
-            if impl:
-                r = impl()
-                if r is not None:
-                    self.sendresponse(r)
-            else:
-                self.sendresponse("")
+            self.sendresponse("")
         return cmd != ''
 
     def _client(self):