fileset: drop bad "elif:" trying to check invalid size expression
authorYuya Nishihara <yuya@tcha.org>
Thu, 01 Mar 2018 04:50:22 -0500
changeset 36535 db33c5bc781f
parent 36534 b075f45456a5
child 36536 74c033b9d579
fileset: drop bad "elif:" trying to check invalid size expression Since str.isdigit is a function, the last "elif" was always true. An invalid expression is rejected by util.sizetoint(), so we don't need "elif".
mercurial/fileset.py
--- a/mercurial/fileset.py	Thu Mar 01 08:55:39 2018 -0500
+++ b/mercurial/fileset.py	Thu Mar 01 04:50:22 2018 -0500
@@ -392,11 +392,10 @@
     elif expr.startswith(">"):
         a = util.sizetoint(expr[1:])
         return lambda x: x > a
-    elif expr[0:1].isdigit or expr.startswith('.'):
+    else:
         a = util.sizetoint(expr)
         b = _sizetomax(expr)
         return lambda x: x >= a and x <= b
-    raise error.ParseError(_("couldn't parse size: %s") % expr)
 
 @predicate('size(expression)', callexisting=True)
 def size(mctx, x):