changeset 33784:dcdc17551653

largefiles: remove remotestore.batch() This method was added in 9e1616307c4c. AFAICT it didn't do anything at inception. If it did, there was no test coverage for it because changing it to raise doesn't fail any tests at that revision. b6e71f8af5b8 later refactored all remote.batch() calls to remote.iterbatch(). So if this was somehow used, it isn't called any more because there are no calls to .batch() remaining in the repo. I suspect the original patch author got confused by the distinction between the peer/remote interface and the largefiles store. The lf store is a gateway to a peer instance. It exposes additional lf-specific methods to execute against a peer. However, it is not a peer and doesn't need to implement batch() because peer itself does that. Differential Revision: https://phab.mercurial-scm.org/D316
author Gregory Szorc <gregory.szorc@gmail.com>
date Wed, 09 Aug 2017 21:04:03 -0700
parents c26a76e1af36
children 297d1b70685c
files hgext/largefiles/remotestore.py
diffstat 1 files changed, 0 insertions(+), 5 deletions(-) [+]
line wrap: on
line diff
--- a/hgext/largefiles/remotestore.py	Fri Aug 11 15:20:41 2017 +0200
+++ b/hgext/largefiles/remotestore.py	Wed Aug 09 21:04:03 2017 -0700
@@ -12,7 +12,6 @@
 from mercurial import (
     error,
     util,
-    wireproto,
 )
 
 from . import (
@@ -109,10 +108,6 @@
                                            'from statlfile (%r)' % stat)
         return failed
 
-    def batch(self):
-        '''Support for remote batching.'''
-        return wireproto.remotebatch(self)
-
     def _put(self, hash, fd):
         '''Put file with the given hash in the remote store.'''
         raise NotImplementedError('abstract method')