Mercurial > hg-stable
changeset 49887:e1953a34c110
bundle: emit full snapshot as is, without doing a redelta
With the new `forced` delta-reused policy, it become important to be able to
send full snapshot where full snapshot are needed. Otherwise, the fallback delta
will simply be used on the client side… creating monstrous delta chain, since
revision that are meant as a reset of delta-chain chain becoming too complex are
simply adding a new full delta-tree on the leaf of another one.
In the `non-forced` cases, client process full snapshot from the bundle
differently from deltas, so client will still try to convert the full snapshot
into a delta if possible. So this will no lead to pathological storage
explosion.
I have considered making this configurable, but the impact seems limited enough
that it does not seems to be worth it. Especially with the current
sparse-revlog format that use "delta-tree" with multiple level snapshots, full
snapshot are much less frequent and not that different from other intermediate
snapshot that we are already sending over the wire anyway.
CPU wise, this will help the bundling side a little as it will not need to
reconstruct revisions and compute deltas. The unbundling side might save a tiny
amount of CPU as it won't need to reconstruct the delta-base to reconstruct the
revision full text. This only slightly visible in some of the benchmarks. And
have no real impact on most of them.
### data-env-vars.name = pypy-2018-08-01-zstd-sparse-revlog
# benchmark.name = perf-bundle
# benchmark.variants.revs = last-40000
before: 11.467186 seconds
just-emit-full: 11.190576 seconds (-2.41%)
with-pull-force: 11.041091 seconds (-3.72%)
# benchmark.name = perf-unbundle
# benchmark.variants.revs = last-40000
before: 16.744862
just-emit-full:: 16.561036 seconds (-1.10%)
with-pull-force: 16.389344 seconds (-2.12%)
# benchmark.name = pull
# benchmark.variants.revs = last-40000
before: 26.870569
just-emit-full: 26.391188 seconds (-1.78%)
with-pull-force: 25.633184 seconds (-4.60%)
Space wise (so network-wise) the impact is fairly small. When taking compression into
account.
Below are tests the size of `hg bundle --all` for a handful of benchmark repositories
(with bzip, zstd compression and without it)
This show a small increase in the bundle size, but nothing really significant
except maybe for mozilla-try (+12%) that nobody really pulls large chunk of anyway.
Mozilla-try is also the repository that benefit the most for not having to
recompute deltas client size.
### mercurial:
bzip-before: 26 406 342 bytes
bzip-after: 26 691 543 bytes +1.08%
zstd-before: 27 918 645 bytes
zstd-after: 28 075 896 bytes +0.56%
none-before: 98 675 601 bytes
none-after: 100 411 237 bytes +1.76%
### pypy
bzip-before: 201 295 752 bytes
bzip-after: 209 780 282 bytes +4.21%
zstd-before: 202 974 795 bytes
zstd-after: 205 165 780 bytes +1.08%
none-before: 871 070 261 bytes
none-after: 993 595 057 bytes +14.07%
### netbeans
bzip-before: 601 314 330 bytes
bzip-after: 614 246 241 bytes +2.15%
zstd-before: 604 745 136 bytes
zstd-after: 615 497 705 bytes +1.78%
none-before: 3 338 238 571 bytes
none-after: 3 439 422 535 bytes +3.03%
### mozilla-central
bzip-before: 1 493 006 921 bytes
bzip-after: 1 549 650 570 bytes +3.79%
zstd-before: 1 481 910 102 bytes
zstd-after: 1 513 052 415 bytes +2.10%
none-before: 6 535 929 910 bytes
none-after: 7 010 191 342 bytes +7.26%
### mozilla-try
bzip-before: 6 583 425 999 bytes
bzip-after: 7 423 536 928 bytes +12.76%
zstd-before: 6 021 009 212 bytes
zstd-after: 6 674 922 420 bytes +10.86%
none-before: 22 954 739 558 bytes
none-after: 26 013 854 771 bytes +13.32%
| author | Pierre-Yves David <pierre-yves.david@octobus.net> |
|---|---|
| date | Wed, 07 Dec 2022 20:12:23 +0100 |
| parents | acdb9a15137c |
| children | 8147abc05794 |
| files | mercurial/utils/storageutil.py tests/test-commit-amend.t tests/test-infinitepush.t tests/test-largefiles.t tests/test-rebase-conflicts.t tests/test-revlog-delta-find.t |
| diffstat | 6 files changed, 34 insertions(+), 13 deletions(-) [+] |
line wrap: on
line diff
--- a/mercurial/utils/storageutil.py Tue Dec 06 12:10:31 2022 +0100 +++ b/mercurial/utils/storageutil.py Wed Dec 07 20:12:23 2022 +0100 @@ -458,6 +458,10 @@ if debug_info is not None: debug_delta_source = "storage" baserev = deltaparentrev + elif deltaparentrev == nullrev: + if debug_info is not None: + debug_delta_source = "storage" + baserev = deltaparentrev else: if deltaparentrev != nullrev and debug_info is not None: debug_info['denied-base-not-available'] += 1
--- a/tests/test-commit-amend.t Tue Dec 06 12:10:31 2022 +0100 +++ b/tests/test-commit-amend.t Wed Dec 07 20:12:23 2022 +0100 @@ -123,13 +123,13 @@ uncompressed size of bundle content: 254 (changelog) 163 (manifests) - 131 a + 133 a saved backup bundle to $TESTTMP/repo/.hg/strip-backup/47343646fa3d-c2758885-amend.hg 1 changesets found uncompressed size of bundle content: 250 (changelog) 163 (manifests) - 131 a + 133 a adding branch adding changesets adding manifests @@ -267,13 +267,13 @@ uncompressed size of bundle content: 249 (changelog) 163 (manifests) - 133 a + 135 a saved backup bundle to $TESTTMP/repo/.hg/strip-backup/a9a13940fc03-7c2e8674-amend.hg 1 changesets found uncompressed size of bundle content: 257 (changelog) 163 (manifests) - 133 a + 135 a adding branch adding changesets adding manifests @@ -303,13 +303,13 @@ uncompressed size of bundle content: 257 (changelog) 163 (manifests) - 133 a + 135 a saved backup bundle to $TESTTMP/repo/.hg/strip-backup/64a124ba1b44-10374b8f-amend.hg 1 changesets found uncompressed size of bundle content: 257 (changelog) 163 (manifests) - 135 a + 137 a adding branch adding changesets adding manifests
--- a/tests/test-infinitepush.t Tue Dec 06 12:10:31 2022 +0100 +++ b/tests/test-infinitepush.t Wed Dec 07 20:12:23 2022 +0100 @@ -46,8 +46,8 @@ remote: bc22f9a30a82 multihead1 remote: ee4802bf6864 multihead2 $ scratchnodes - bc22f9a30a821118244deacbd732e394ed0b686c ab1bc557aa090a9e4145512c734b6e8a828393a5 - ee4802bf6864326a6b3dcfff5a03abc2a0a69b8f ab1bc557aa090a9e4145512c734b6e8a828393a5 + bc22f9a30a821118244deacbd732e394ed0b686c de1b7d132ba98f0172cd974e3e69dfa80faa335c + ee4802bf6864326a6b3dcfff5a03abc2a0a69b8f de1b7d132ba98f0172cd974e3e69dfa80faa335c Create two new scratch bookmarks $ hg up 0
--- a/tests/test-largefiles.t Tue Dec 06 12:10:31 2022 +0100 +++ b/tests/test-largefiles.t Wed Dec 07 20:12:23 2022 +0100 @@ -1122,7 +1122,7 @@ 6 changesets found uncompressed size of bundle content: 1389 (changelog) - 1599 (manifests) + 1698 (manifests) 254 .hglf/large1 564 .hglf/large3 572 .hglf/sub/large4
--- a/tests/test-rebase-conflicts.t Tue Dec 06 12:10:31 2022 +0100 +++ b/tests/test-rebase-conflicts.t Wed Dec 07 20:12:23 2022 +0100 @@ -315,7 +315,7 @@ adding manifests adding file changes adding f1.txt revisions - bundle2-input-part: total payload size 1686 + bundle2-input-part: total payload size 1739 bundle2-input-part: "cache:rev-branch-cache" (advisory) supported bundle2-input-part: total payload size 74 bundle2-input-part: "phase-heads" supported
--- a/tests/test-revlog-delta-find.t Tue Dec 06 12:10:31 2022 +0100 +++ b/tests/test-revlog-delta-find.t Wed Dec 07 20:12:23 2022 +0100 @@ -296,6 +296,21 @@ DBG-DELTAS: FILELOG:my-file.txt: rev=3: delta-base=2 * (glob) DBG-DELTAS: FILELOG:my-file.txt: rev=4: delta-base=4 * (glob) +Check that "forced" behavior do not challenge the delta, even if it is full. +--------------------------------------------------------------------------- + +A full bundle should be accepted as full bundle without recomputation + + $ cp -ar local-pre-pull-full local-forced-full + $ hg -R local-forced-full pull --quiet \ + > --config 'paths.default:delta-reuse-policy=forced' + DBG-DELTAS: CHANGELOG: * (glob) + DBG-DELTAS: CHANGELOG: * (glob) + DBG-DELTAS: MANIFESTLOG: * (glob) + DBG-DELTAS: MANIFESTLOG: * (glob) + DBG-DELTAS: FILELOG:my-file.txt: rev=3: delta-base=2 * (glob) + DBG-DELTAS: FILELOG:my-file.txt: rev=4: delta-base=4 is-cached=1 - search-rounds=0 try-count=0 - delta-type=full snap-depth=0 - * (glob) + Check that "forced" behavior do not challenge the delta, even if it is bad. --------------------------------------------------------------------------- @@ -305,9 +320,11 @@ (as the server won't be sending "bad" deltas anymore) and might need something more subtle to test this behavior. - $ cp -ar local-pre-pull-full local-forced-full - $ hg -R local-forced-full pull --quiet \ - > --config 'paths.default:delta-reuse-policy=forced' + $ hg bundle -R peer-bad-delta-with-full --all --config devel.bundle.delta=p1 all-p1.hg + 5 changesets found + $ cp -ar local-pre-pull-full local-forced-full-p1 + $ hg -R local-forced-full-p1 pull --quiet \ + > --config 'paths.*:delta-reuse-policy=forced' all-p1.hg DBG-DELTAS: CHANGELOG: * (glob) DBG-DELTAS: CHANGELOG: * (glob) DBG-DELTAS: MANIFESTLOG: * (glob)