Mercurial > hg-stable
changeset 13130:f139f34ba330
progress: react more reasonably to nested progress topics
Previously, we'd reset the entire progress bar state when a topic was
completed, even if it wasn't the outermost progress topic. Now we
print the state of the next progress topic on the stack if one is left
rather than reset the progress bar.
| author | Augie Fackler <durin42@gmail.com> |
|---|---|
| date | Fri, 10 Dec 2010 16:56:12 -0600 |
| parents | 873c032c81b5 |
| children | c9ae7e096994 |
| files | hgext/progress.py tests/test-convert-svn-move.t |
| diffstat | 2 files changed, 12 insertions(+), 10 deletions(-) [+] |
line wrap: on
line diff
--- a/hgext/progress.py Mon Dec 13 12:19:26 2010 -0600 +++ b/hgext/progress.py Fri Dec 10 16:56:12 2010 -0600 @@ -61,6 +61,7 @@ def resetstate(self): self.topics = [] + self.topicstates = {} self.printed = False self.lastprint = time.time() + float(self.ui.config( 'progress', 'delay', default=3)) @@ -161,17 +162,24 @@ def progress(self, topic, pos, item='', unit='', total=None): if pos is None: - if self.topics and self.topics[-1] == topic and self.printed: + self.topicstates.pop(topic, None) + # reset the progress bar if this is the outermost topic + if self.topics and self.topics[0] == topic and self.printed: self.complete() self.resetstate() + # truncate the list of topics assuming all topics within + # this one are also closed + if topic in self.topics: + self.topics = self.topics[:self.topics.index(topic)] else: if topic not in self.topics: self.topics.append(topic) now = time.time() - if (now - self.lastprint >= self.refresh - and topic == self.topics[-1]): + self.topicstates[topic] = pos, item, unit, total + if now - self.lastprint >= self.refresh and self.topics: self.lastprint = now - self.show(topic, pos, item, unit, total) + current = self.topics[-1] + self.show(current, *self.topicstates[current]) def uisetup(ui): class progressui(ui.__class__):
--- a/tests/test-convert-svn-move.t Mon Dec 13 12:19:26 2010 -0600 +++ b/tests/test-convert-svn-move.t Fri Dec 10 16:56:12 2010 -0600 @@ -196,13 +196,11 @@ converting [=======> ] 1/7 scanning paths [ ] 0/1 - getting files [==========================================================>] 1/1 converting [================> ] 2/7 scanning paths [ ] 0/2 scanning paths [============================> ] 1/2 - getting files [=============> ] 1/4 getting files [============================> ] 2/4 getting files [===========================================> ] 3/4 @@ -210,19 +208,16 @@ converting [=========================> ] 3/7 scanning paths [ ] 0/1 - getting files [==========================================================>] 1/1 converting [==================================> ] 4/7 scanning paths [ ] 0/1 - getting files [==========================================================>] 1/1 converting [===========================================> ] 5/7 scanning paths [ ] 0/3 scanning paths [==================> ] 1/3 scanning paths [=====================================> ] 2/3 - getting files [======> ] 1/8 getting files [=============> ] 2/8 getting files [=====================> ] 3/8 @@ -234,7 +229,6 @@ converting [====================================================> ] 6/7 scanning paths [ ] 0/1 - getting files [======> ] 1/8 getting files [=============> ] 2/8 getting files [=====================> ] 3/8