narrow: pass binary nodeids to generateellipsesbundle2()
authorPulkit Goyal <pulkit@yandex-team.ru>
Fri, 24 May 2019 15:57:00 +0300
changeset 42390 f66628c15e6f
parent 42389 96fc696a9cb2
child 42391 343b3ed35cb8
narrow: pass binary nodeids to generateellipsesbundle2() We generally work with binary nodeids and it's should be expected that new function gets the nodeids in binary form already. Differential Revision: https://phab.mercurial-scm.org/D6444
hgext/narrow/narrowbundle2.py
--- a/hgext/narrow/narrowbundle2.py	Fri May 24 12:33:46 2019 +0200
+++ b/hgext/narrow/narrowbundle2.py	Fri May 24 15:57:00 2019 +0300
@@ -61,8 +61,9 @@
     oldexclude = sorted(filter(bool, kwargs.get(r'oldexcludepats', [])))
     newinclude = sorted(filter(bool, kwargs.get(r'includepats', [])))
     newexclude = sorted(filter(bool, kwargs.get(r'excludepats', [])))
+    known = {bin(n) for n in kwargs.get('known', [])}
     generateellipsesbundle2(bundler, repo, oldinclude, oldexclude, newinclude,
-            newexclude, version, common, kwargs.get('known', []),
+            newexclude, version, common, known,
             kwargs.get(r'depth', None), heads)
 
 def generateellipsesbundle2(bundler, repo, oldinclude, oldexclude, newinclude,
@@ -76,7 +77,6 @@
 
     heads = set(heads or repo.heads())
     common = set(common or [nullid])
-    known = {bin(n) for n in known}
     if known and (oldinclude != newinclude or oldexclude != newexclude):
         # Steps:
         # 1. Send kill for "$known & ::common"