hgweb.manifest: revno of manifest and changelog aren't always the same
authorAlexis S. L. Carvalho <alexis@cecm.usp.br>
Sat, 20 May 2006 15:34:19 -0300
changeset 2328 f789602ba840
parent 2327 185cb7fffbeb
child 2329 90368f89340a
hgweb.manifest: revno of manifest and changelog aren't always the same In the v4l-dvb repo, the manifest revno and the changelog revno are not in sync. This happened because the same patch was applied to the same revision in two different branches, resulting in the same manifest text, with the same parents and so the first revision was reused. Since hgweb.manifest was assuming the revnos of the manifest and of the changelog were always the same, clicking on manifest -> bz2 in the v4l-dvb site would download the wrong revision. Use the linkrev to go from manifest revision to changelog revision. This still won't be perfect since the page will still talk about "manifest for changeset XYZ", where XYZ was the first changeset to have this manifest, which is not necessarily the same changeset that the user clicked to get to this page - but at least the contents will be the same.
mercurial/hgweb/__init__.py
--- a/mercurial/hgweb/__init__.py	Fri May 19 14:58:13 2006 -0700
+++ b/mercurial/hgweb/__init__.py	Sat May 20 15:34:19 2006 -0300
@@ -519,7 +519,8 @@
         mnode = hex(mn)
         mf = man.read(mn)
         rev = man.rev(mn)
-        node = self.repo.changelog.node(rev)
+        changerev = man.linkrev(mn)
+        node = self.repo.changelog.node(changerev)
         mff = man.readflags(mn)
 
         files = {}