Mercurial > hg-stable
changeset 38313:fabfbbf4dee2
templatefilters: rename commonprefix to commondir
Two reasons:
* It makes it clearer that it's not a generic common string
prefix (e.g. commonprefix(["bar", "baz"]) is not "ba", but "")
* If we ever want a filter for generic common string prefix,
then the name is now available for that.
"commondir" does not describe the prefix-ness, however. I'm happy to
rename it "commondirprefix" or "commonprefixdir" if others prefer.
Differential Revision: https://phab.mercurial-scm.org/D3731
| author | Martin von Zweigbergk <martinvonz@google.com> |
|---|---|
| date | Wed, 13 Jun 2018 14:28:39 -0700 |
| parents | 1fb2510cf8c8 |
| children | 1445b556e9d2 |
| files | mercurial/templatefilters.py tests/test-template-filters.t |
| diffstat | 2 files changed, 13 insertions(+), 13 deletions(-) [+] |
line wrap: on
line diff
--- a/mercurial/templatefilters.py Wed Jun 13 10:24:44 2018 -0400 +++ b/mercurial/templatefilters.py Wed Jun 13 14:28:39 2018 -0700 @@ -99,8 +99,8 @@ """ return os.path.basename(path) -@templatefilter('commonprefix') -def commonprefix(filelist): +@templatefilter('commondir') +def commondir(filelist): """List of text. Treats each list item as file name with / as path separator and returns the longest common directory prefix shared by all list items.
--- a/tests/test-template-filters.t Wed Jun 13 10:24:44 2018 -0400 +++ b/tests/test-template-filters.t Wed Jun 13 14:28:39 2018 -0700 @@ -1,23 +1,23 @@ - $ hg debugtemplate '{""|splitlines|commonprefix}\n' + $ hg debugtemplate '{""|splitlines|commondir}\n' - $ hg debugtemplate '{"foo/bar\nfoo/baz\nfoo/foobar\n"|splitlines|commonprefix}\n' + $ hg debugtemplate '{"foo/bar\nfoo/baz\nfoo/foobar\n"|splitlines|commondir}\n' foo - $ hg debugtemplate '{"foo/bar\nfoo/bar\n"|splitlines|commonprefix}\n' + $ hg debugtemplate '{"foo/bar\nfoo/bar\n"|splitlines|commondir}\n' foo - $ hg debugtemplate '{"/foo/bar\n/foo/bar\n"|splitlines|commonprefix}\n' + $ hg debugtemplate '{"/foo/bar\n/foo/bar\n"|splitlines|commondir}\n' foo - $ hg debugtemplate '{"/foo\n/foo\n"|splitlines|commonprefix}\n' + $ hg debugtemplate '{"/foo\n/foo\n"|splitlines|commondir}\n' - $ hg debugtemplate '{"foo/bar\nbar/baz"|splitlines|commonprefix}\n' + $ hg debugtemplate '{"foo/bar\nbar/baz"|splitlines|commondir}\n' - $ hg debugtemplate '{"foo/bar\nbar/baz\nbar/foo\n"|splitlines|commonprefix}\n' + $ hg debugtemplate '{"foo/bar\nbar/baz\nbar/foo\n"|splitlines|commondir}\n' - $ hg debugtemplate '{"foo/../bar\nfoo/bar"|splitlines|commonprefix}\n' + $ hg debugtemplate '{"foo/../bar\nfoo/bar"|splitlines|commondir}\n' foo - $ hg debugtemplate '{"foo\n/foo"|splitlines|commonprefix}\n' + $ hg debugtemplate '{"foo\n/foo"|splitlines|commondir}\n' $ hg init - $ hg log -r null -T '{rev|commonprefix}' + $ hg log -r null -T '{rev|commondir}' hg: parse error: argument is not a list of text - (template filter 'commonprefix' is not compatible with keyword 'rev') + (template filter 'commondir' is not compatible with keyword 'rev') [255]