Mercurial > hg
annotate tests/.balto.toml @ 41163:0101a35deae2
phabricator: warn if unable to amend, instead of aborting after posting
There was a divergence in behavior here between obsolete and strip based
amending. I first noticed the abort when testing outside of the test harness,
but then had trouble recreating it here after reverting the code changes. It
turns out, strip based amend was successfully amending the public commit after
it was posted! It looks like the protection is in the `commit --amend` command,
not in the underlying code that it calls.
I considered doing a preflight check and aborting. But the locks are only
acquired at the end, if amending, and this is too large a section of code to be
wrapped in a maybe-it's-held-or-not context manager for my tastes.
Additionally, some people do post-push reviews, and amending is the default
behavior, so they shouldn't see a misleading error message.
The lack of a 'Differential Revision' entry in the commit message breaks a
{phabreview} test, so it had to be partially conditionalized.
author | Matt Harbison <matt_harbison@yahoo.com> |
---|---|
date | Sat, 05 Jan 2019 15:20:33 -0500 |
parents | 337a38995336 |
children |
rev | line source |
---|---|
40673
337a38995336
tests: add Balto configuration file
Boris Feld <boris.feld@octobus.net>
parents:
diff
changeset
|
1 # Balto (https://bitbucket.org/lothiraldan/balto/src) is a test orchestrator |
337a38995336
tests: add Balto configuration file
Boris Feld <boris.feld@octobus.net>
parents:
diff
changeset
|
2 # which is compatible with all test runner that can emit the LITF |
337a38995336
tests: add Balto configuration file
Boris Feld <boris.feld@octobus.net>
parents:
diff
changeset
|
3 # (https://github.com/lothiraldan/litf) test format. |
337a38995336
tests: add Balto configuration file
Boris Feld <boris.feld@octobus.net>
parents:
diff
changeset
|
4 |
337a38995336
tests: add Balto configuration file
Boris Feld <boris.feld@octobus.net>
parents:
diff
changeset
|
5 # The plugin for the Mercurial test runner is mercurial-litf |
337a38995336
tests: add Balto configuration file
Boris Feld <boris.feld@octobus.net>
parents:
diff
changeset
|
6 # (https://pypi.org/project/mercurial-litf/). Make sure to follow the |
337a38995336
tests: add Balto configuration file
Boris Feld <boris.feld@octobus.net>
parents:
diff
changeset
|
7 # instruction and configuration instructions here: |
337a38995336
tests: add Balto configuration file
Boris Feld <boris.feld@octobus.net>
parents:
diff
changeset
|
8 # https://bitbucket.org/lothiraldan/mercurial_litf/src/default/ |
337a38995336
tests: add Balto configuration file
Boris Feld <boris.feld@octobus.net>
parents:
diff
changeset
|
9 |
337a38995336
tests: add Balto configuration file
Boris Feld <boris.feld@octobus.net>
parents:
diff
changeset
|
10 # You can launch Balto with `balto /path/to/mercurial/tests/` |
337a38995336
tests: add Balto configuration file
Boris Feld <boris.feld@octobus.net>
parents:
diff
changeset
|
11 |
337a38995336
tests: add Balto configuration file
Boris Feld <boris.feld@octobus.net>
parents:
diff
changeset
|
12 name = "Mercurial Test Suite" |
337a38995336
tests: add Balto configuration file
Boris Feld <boris.feld@octobus.net>
parents:
diff
changeset
|
13 tool = "mercurial" |