Mercurial > hg
annotate tests/test-check-shbang.t @ 41163:0101a35deae2
phabricator: warn if unable to amend, instead of aborting after posting
There was a divergence in behavior here between obsolete and strip based
amending. I first noticed the abort when testing outside of the test harness,
but then had trouble recreating it here after reverting the code changes. It
turns out, strip based amend was successfully amending the public commit after
it was posted! It looks like the protection is in the `commit --amend` command,
not in the underlying code that it calls.
I considered doing a preflight check and aborting. But the locks are only
acquired at the end, if amending, and this is too large a section of code to be
wrapped in a maybe-it's-held-or-not context manager for my tastes.
Additionally, some people do post-push reviews, and amending is the default
behavior, so they shouldn't see a misleading error message.
The lack of a 'Differential Revision' entry in the commit message breaks a
{phabreview} test, so it had to be partially conditionalized.
author | Matt Harbison <matt_harbison@yahoo.com> |
---|---|
date | Sat, 05 Jan 2019 15:20:33 -0500 |
parents | ddd65b4f3ae6 |
children | 2d8d4e08c493 |
rev | line source |
---|---|
28879
8c1759a2bdf4
tests: add new test for #! shebang lines
timeless <timeless@mozdev.org>
parents:
27569
diff
changeset
|
1 #require test-repo |
27569 | 2 |
29219
3c9066ed557c
tests: silence test-repo obsolete warning
timeless <timeless@mozdev.org>
parents:
28879
diff
changeset
|
3 $ . "$TESTDIR/helpers-testrepo.sh" |
27569 | 4 $ cd "`dirname "$TESTDIR"`" |
5 | |
28879
8c1759a2bdf4
tests: add new test for #! shebang lines
timeless <timeless@mozdev.org>
parents:
27569
diff
changeset
|
6 look for python scripts that do not use /usr/bin/env |
27569 | 7 |
33204
ddd65b4f3ae6
tests: alias syshg and syshgenv so they can be switched conditionally
Yuya Nishihara <yuya@tcha.org>
parents:
33116
diff
changeset
|
8 $ testrepohg files 'set:grep(r"^#!.*?python") and not grep(r"^#!/usr/bi{1}n/env python") - **/*.t' |
27569 | 9 [1] |
10 | |
32939
cad62cb3c84c
tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents:
29515
diff
changeset
|
11 In tests, enforce $PYTHON and *not* /usr/bin/env python or similar: |
33204
ddd65b4f3ae6
tests: alias syshg and syshgenv so they can be switched conditionally
Yuya Nishihara <yuya@tcha.org>
parents:
33116
diff
changeset
|
12 $ testrepohg files 'set:grep(r"#!.*?python") and **/*.t' \ |
32939
cad62cb3c84c
tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents:
29515
diff
changeset
|
13 > -X tests/test-check-execute.t \ |
cad62cb3c84c
tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents:
29515
diff
changeset
|
14 > -X tests/test-check-module-imports.t \ |
cad62cb3c84c
tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents:
29515
diff
changeset
|
15 > -X tests/test-check-pyflakes.t \ |
cad62cb3c84c
tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents:
29515
diff
changeset
|
16 > -X tests/test-check-shbang.t |
cad62cb3c84c
tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents:
29515
diff
changeset
|
17 [1] |
cad62cb3c84c
tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents:
29515
diff
changeset
|
18 |
cad62cb3c84c
tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents:
29515
diff
changeset
|
19 The above exclusions are because they're looking for files that |
cad62cb3c84c
tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents:
29515
diff
changeset
|
20 contain Python but don't end in .py - please avoid adding more. |
cad62cb3c84c
tests: enforce use of $PYTHON in tests
Augie Fackler <augie@google.com>
parents:
29515
diff
changeset
|
21 |
28879
8c1759a2bdf4
tests: add new test for #! shebang lines
timeless <timeless@mozdev.org>
parents:
27569
diff
changeset
|
22 look for shell scripts that do not use /bin/sh |
27569 | 23 |
33204
ddd65b4f3ae6
tests: alias syshg and syshgenv so they can be switched conditionally
Yuya Nishihara <yuya@tcha.org>
parents:
33116
diff
changeset
|
24 $ testrepohg files 'set:grep(r"^#!.*/bi{1}n/sh") and not grep(r"^#!/bi{1}n/sh")' |
27569 | 25 [1] |